Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[automated]: crowdin sync, enables turkish #7089

Open
wants to merge 114 commits into
base: main
Choose a base branch
from
Open

Conversation

nodejs-crowdin
Copy link
Collaborator

@nodejs-crowdin nodejs-crowdin commented Oct 4, 2024

Brian: turned this one around so fast because Turkish will be ready to go.
Will get ready tonight

image

@nodejs-crowdin nodejs-crowdin requested a review from a team as a code owner October 4, 2024 22:06
@nodejs-crowdin nodejs-crowdin added the github_actions:pull-request Trigger Pull Request Checks label Oct 4, 2024
Copy link

vercel bot commented Oct 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Oct 5, 2024 0:58am

@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Oct 4, 2024
Copy link

github-actions bot commented Oct 4, 2024

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 94 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 99 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 99 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 100 🟢 92 🔗

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@bmuenzenmeyer bmuenzenmeyer changed the title [automated]: crowdin sync [automated]: crowdin sync, enables turkish Oct 5, 2024
@bmuenzenmeyer
Copy link
Collaborator

there are some quality errors we need to sort out here

  • lints, as reported
  • props that are translated
<Release.DownloadButton kind={"yükleyici"} />
</section>

@isarikaya
Copy link

I fixed the prop values. I also double checked all the files in crowdin.

<Release.DownloadButton kind={"yükleyici"} /></section>
<Release.DownloadButton kind={"ikili"}/>

@ovflowd
Copy link
Member

ovflowd commented Oct 6, 2024

@ovflowd
Copy link
Member

ovflowd commented Oct 6, 2024

We can edit the sources manually here also, but ideally changes should be done on Crowdin

@isarikaya
Copy link

I will fix this on crowdin once I run this PR on my local and fully understand the errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants