Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6492 surfin 404 #7056

Merged
merged 9 commits into from
Sep 25, 2024
Merged

6492 surfin 404 #7056

merged 9 commits into from
Sep 25, 2024

Conversation

bmuenzenmeyer
Copy link
Collaborator

@bmuenzenmeyer bmuenzenmeyer commented Sep 23, 2024

Description

I spent the weekend chipping away at @darcyclarke's rocket turtle animation. This will land the longest open PR we have, and it's an important bit of style 😎

Validation

Go to a non-existent page locally or on the preview.
Tested with
Chrome, Firefox, Edge

Existing Chrome Firefox Edge
image image image image

Mobile

Existing New
Screenshot_20240923_072453_Chrome.jpg Screenshot_20240923_072441_Chrome.jpg

Turn on prefers reduced motion, in your operating system of choice.

After a bit, see the up and down animation cease to loop.

Related Issues

closes #6492
relates to #6480

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

Copy link

vercel bot commented Sep 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Sep 24, 2024 10:41am

@bmuenzenmeyer bmuenzenmeyer marked this pull request as ready for review September 23, 2024 11:52
@bmuenzenmeyer bmuenzenmeyer requested a review from a team as a code owner September 23, 2024 11:52
Copy link
Collaborator Author

@bmuenzenmeyer bmuenzenmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self-review, open to suggestions, especially on the tailwind conversion

apps/site/app/[locale]/not-found.tsx Outdated Show resolved Hide resolved
apps/site/app/[locale]/not-found.tsx Show resolved Hide resolved
apps/site/styles/effects.css Outdated Show resolved Hide resolved
apps/site/tailwind.config.ts Show resolved Hide resolved
apps/site/app/[locale]/not-found.tsx Show resolved Hide resolved
@bmuenzenmeyer bmuenzenmeyer marked this pull request as draft September 23, 2024 12:01
@bmuenzenmeyer

This comment was marked as resolved.

@ovflowd

This comment was marked as resolved.

@bmuenzenmeyer

This comment was marked as resolved.

@bmuenzenmeyer

This comment was marked as resolved.

at least on Chrome responsive mode this looks better. still testing
@bmuenzenmeyer
Copy link
Collaborator Author

On mobile text is not centered and the image overlaps with the bottom text.

@ovflowd can you look again, this looks correct to me now on my phone. If you are concerned about the text, that is unrelated to the PR - this only alters the image

@ovflowd

This comment was marked as resolved.

@bmuenzenmeyer

This comment was marked as resolved.

Copy link
Member

@canerakdas canerakdas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really cool 😍 I have added a few minor comments about the Tailwind conversion

apps/site/styles/effects.css Outdated Show resolved Hide resolved
apps/site/styles/effects.css Outdated Show resolved Hide resolved
apps/site/styles/effects.css Outdated Show resolved Hide resolved
@darcyclarke
Copy link
Member

@bmuenzenmeyer thanks for helping get this over the finish line <3

@darcyclarke darcyclarke mentioned this pull request Sep 23, 2024
5 tasks
@ovflowd
Copy link
Member

ovflowd commented Sep 23, 2024

Page could not be found still not centered for me 🙈

it never was, from what i can tell of current production. we can center it if you like.

Let's center it :D

bmuenzenmeyer and others added 2 commits September 23, 2024 22:40
Co-authored-by: Caner Akdas <[email protected]>
Signed-off-by: Brian Muenzenmeyer <[email protected]>
did not alter .special, as that is used for the homepage
Copy link

github-actions bot commented Sep 24, 2024

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 99 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 100 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 100 🟢 92 🔗

Copy link

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
90.47% (589/651) 76.29% (177/232) 94.35% (117/124)

Unit Test Report

Tests Skipped Failures Errors Time
131 0 💤 0 ❌ 0 🔥 5.234s ⏱️

Copy link
Contributor

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Cool new feature

Copy link
Member

@canerakdas canerakdas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bmuenzenmeyer bmuenzenmeyer added this pull request to the merge queue Sep 25, 2024
Merged via the queue into main with commit 29e64d7 Sep 25, 2024
15 checks passed
@bmuenzenmeyer bmuenzenmeyer deleted the 6492-surfin-404 branch September 25, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants