Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add x64-debug #26

Merged
merged 2 commits into from
Jan 31, 2024
Merged

feat: add x64-debug #26

merged 2 commits into from
Jan 31, 2024

Conversation

matthewkeil
Copy link
Contributor

NOTE: Reopened PR #25. Please see that PR for comments and commit history

This adds support for an unofficial-build that is added in nodejs/unofficial-builds#107

attn: @rvagg

@matthewkeil
Copy link
Contributor Author

Please double check this. I think its correct but would love a keen eye @rvagg !!! Thanks again!

@matthewkeil
Copy link
Contributor Author

Thanks @richardlau!

UlisesGascon
UlisesGascon approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@matthewkeil
Copy link
Contributor Author

Thanks @UlisesGascon !

@rvagg rvagg merged commit 0b360f6 into nodejs:main Jan 31, 2024
github-actions bot pushed a commit that referenced this pull request Jan 31, 2024
@semantic-release-bot
chore(release): 1.7.0 [skip ci]
f32294a 
## [1.7.0](v1.6.1...v1.7.0) (2024-01-31)

### Features

* add x64-debug ([#26](#26)) ([0b360f6](0b360f6))

### Trivial Changes

* auto releases ([130854e](130854e))
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 1.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvagg rvagg rvagg approved these changes

@UlisesGascon UlisesGascon UlisesGascon approved these changes

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matthewkeil @rvagg @UlisesGascon @richardlau