assert: allow printf-style messages as assertion error #58849
+49
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add functions as allowed message input. This allows to have leavy message computation to become cheaper.
BridgeAR
added
the
semver-minor
nodejs-github-bot
added
assert
avivkeller
reviewed
Jun 27, 2025
| @@ -165,7 +183,7 @@ assert.equal = function equal(actual, expected, message) { | |||
| * @param {string | Error} [message] | |||
There was a problem hiding this comment.
This type needs to be updated
(I know it's not finished, but other than that, love it!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add functions as allowed message input.
This allows to have heavy message computation to become cheaper.
This is not yet finished, I just thought I could get some early feedback.
Tests are often not as performance sensitive, so it's not that crucial.
I do like the ergonomics of it as well though and I know I worked around
a test perf issue of this kind in Node.js before.