fs: fix for FileHandle.readableWebStream

[pdaehne]

Fixes FileHandle.readableWebStream in mode "byob" when reading into a view that has a byteOffset>0 into the underlying ArrayBuffer.

Fixes: #58817

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/67665/

[mertcanaltin]

LGTM, but I think we need to edit the return byteofset field in cpp to solve this problem, I wonder if I am thinking wrong here

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.08%. Comparing base (100c6da) to head (0421c9e).
Report is 9 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #58842      +/-   ##
==========================================
- Coverage   90.10%   90.08%   -0.02%     
==========================================
  Files         640      640              
  Lines      188384   188446      +62     
  Branches    36932    36964      +32     
==========================================
+ Hits       169735   169758      +23     
- Misses      11356    11409      +53     
+ Partials     7293     7279      -14     

Files with missing lines	Coverage Δ
lib/internal/fs/promises.js	98.09% <100.00%> (ø)

... and 47 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[pdaehne]

@mertcanaltin Have a look at this example in the Streams specification, it is more or less a copy of the code in Node.js, and they also use 0 as the "offset" parameter for "FileHandle.read()":

https://streams.spec.whatwg.org/#example-rbs-pull

[mertcanaltin]

@mertcanaltin Have a look at this example in the Streams specification, it is more or less a copy of the code in Node.js, and they also use 0 as the "offset" parameter for "FileHandle.read()":

thanks!

[LiviaMedeiros]

LGTM, thanks for fixing this!

The correct subsystem (prefix in the commit message) should be fs:, this also can be adjusted by a collaborator who lands it.