test_runner: fix timeout not propagated to the child process in run

[jakecastelli]

We do have test coverage for this case, however, the test failed due to an incorrect file path, not due to the intended testTimeoutFailure. The key takeaway is that we should make the assertion more explicit to avoid such regression.

Fixes: #58802

[nodejs-github-bot]

Review requested:

• @nodejs/test_runner

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.99%. Comparing base (6ce6fdb) to head (7720b96).
Report is 13 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #58831      +/-   ##
==========================================
- Coverage   90.10%   89.99%   -0.12%     
==========================================
  Files         640      640              
  Lines      188384   188369      -15     
  Branches    36937    36862      -75     
==========================================
- Hits       169743   169522     -221     
- Misses      11363    11529     +166     
- Partials     7278     7318      +40     

Files with missing lines	Coverage Δ
lib/internal/test_runner/runner.js	92.68% <100.00%> (+0.03%)	⬆️

... and 40 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[pmarchini]

The key takeaway is that we should make the assertion more explicit to avoid such regression.

@jakecastelli yes I agree.

There's a failure in the test(now two failures seem to be expected)

[jakecastelli]

There's a failure in the test(now two failures seem to be expected)

Ah indeed - missed the other one!

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/67664/

[edsadr]

LGTM