build: do not put commands in sources variables #56885
Open
+22
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
build
github-actions
bot
removed
the
request-ci
zcbenz
force-pushed
the
cctest-sources-gn
branch
from
21bf527 to
8e5fd5a
Compare
zcbenz
force-pushed
the
cctest-sources-gn
branch
from
8e5fd5a to
47cb039
Compare
github-actions
bot
removed
the
request-ci
|
Can we document this rule? Like, add a new gyp-GN inter-op section in https://github.com/nodejs/node/blob/main/doc/contributing/maintaining/maintaining-the-build-files.md. |
|
Didn't know there is a doc on maintaining build files, I will add a section about the GN build in a new pull request, there are more things I want to write down aside from the variables rule. |
legendecas
approved these changes
Feb 3, 2025
richardlau
approved these changes
Feb 3, 2025
legendecas
added
the
commit-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
_sourcesvariables are also read by GN and putting anything other than filenames in them would end up with GN errors.