src: fix process exit listeners not receiving unsettled tla codes

[dario-piotrowicz]

fix listeners registered via process.on('exit', ... not receiving error code 13 when an unsettled top-level-await is encountered in the code

Fixes: #53551

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.16%. Comparing base (2bd5694) to head (80a0041).

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #56872      +/-   ##
==========================================
- Coverage   89.16%   89.16%   -0.01%     
==========================================
  Files         665      665              
  Lines      192602   192600       -2     
  Branches    37050    37051       +1     
==========================================
- Hits       171732   171728       -4     
- Misses      13678    13681       +3     
+ Partials     7192     7191       -1     

Files with missing lines	Coverage Δ
src/api/embed_helpers.cc	74.61% <100.00%> (-0.02%)	⬇️
src/api/hooks.cc	84.44% <100.00%> (+0.72%)	⬆️

... and 23 files with indirect coverage changes

[joyeecheung]

Thanks for the PR. Some comments about the approaches taken.

[joyeecheung]

Can you put these into separate tests? Otherwise we lose coverage of the cases where there isn't any exit handler installed.

[joyeecheung]

I think prior to emitting the event, it should also set the kHasExitCode and kExitCode fields in the exit info buffer (basically needing an implementation of Environment::set_exit_code() that is the counter part of Environment::exit_code) so that in the handler, process.exitCode would be 13, to be consistent with other paths. Also in any case, the documentation of the exit event in doc/api/process.md should also be updated to note this extra source of exit code.