-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: deflake test-watch-file-shared-dependency #56344
Open
lpinca
wants to merge
1
commit into
nodejs:main
Choose a base branch
from
lpinca:deflake/test-watch-file-shared-dependency
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
test: deflake test-watch-file-shared-dependency #56344
lpinca
wants to merge
1
commit into
nodejs:main
from
lpinca:deflake/test-watch-file-shared-dependency
+21
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
PRs that need a full CI run.
test
Issues and PRs related to the tests.
labels
Dec 23, 2024
lpinca
commented
Dec 23, 2024
@@ -49,6 +49,20 @@ describe('watch file with shared dependency', () => { | |||
watcher.unfilterFilesOwnedBy([fixturePaths['test.js']]); | |||
watcher.filterFile(fixturePaths['test.js']); | |||
watcher.filterFile(fixturePaths['dependency.js'], fixturePaths['test.js']); | |||
writeFileSync(fixturePaths['dependency.js'], 'module.exports = { modified: true };'); | |||
|
|||
if (common.isMacOS) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to be flaky only on macOS.
targos
approved these changes
Dec 23, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56344 +/- ##
=======================================
Coverage 88.54% 88.54%
=======================================
Files 657 657
Lines 190395 190395
Branches 36552 36553 +1
=======================================
+ Hits 168580 168587 +7
+ Misses 14993 14990 -3
+ Partials 6822 6818 -4 |
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Dec 23, 2024
lpinca
force-pushed
the
deflake/test-watch-file-shared-dependency
branch
from
December 23, 2024 19:32
7e3ba67
to
8eb0df9
Compare
lpinca
force-pushed
the
deflake/test-watch-file-shared-dependency
branch
2 times, most recently
from
December 23, 2024 19:59
35a07c0
to
4b5f471
Compare
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Dec 23, 2024
Delay dependency file modification on macOS. Refs: nodejs#51842
lpinca
force-pushed
the
deflake/test-watch-file-shared-dependency
branch
from
December 23, 2024 20:09
4b5f471
to
2fe6b2a
Compare
jakecastelli
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delay dependency file modification on macOS.
Refs: #51842