-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib: use Promise.withResolvers()
in timers
#55720
Open
anonrig
wants to merge
1
commit into
nodejs:main
Choose a base branch
from
anonrig:yagiz/use-promise-with-resolvers
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+24
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
PRs that need a full CI run.
timers
Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.
labels
Nov 4, 2024
targos
approved these changes
Nov 4, 2024
targos
added
dont-land-on-v18.x
PRs that should not land on the v18.x-staging branch and should not be released in v18.x.
dont-land-on-v20.x
PRs that should not land on the v20.x-staging branch and should not be released in v20.x.
labels
Nov 4, 2024
MoLow
approved these changes
Nov 4, 2024
anonrig
added
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
request-ci
Add this label to start a Jenkins CI on a PR.
labels
Nov 4, 2024
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Nov 4, 2024
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55720 +/- ##
==========================================
+ Coverage 88.38% 88.40% +0.02%
==========================================
Files 654 654
Lines 187575 187654 +79
Branches 36096 36110 +14
==========================================
+ Hits 165795 165903 +108
+ Misses 15004 14994 -10
+ Partials 6776 6757 -19
|
atlowChemi
approved these changes
Nov 4, 2024
lpinca
approved these changes
Nov 4, 2024
anonrig
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
commit-queue
Add this label to land a pull request using GitHub Actions.
dont-land-on-v18.x
PRs that should not land on the v18.x-staging branch and should not be released in v18.x.
dont-land-on-v20.x
PRs that should not land on the v20.x-staging branch and should not be released in v20.x.
needs-ci
PRs that need a full CI run.
timers
Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's use
Promise.withResolvers()
instead of creating a promise directly.Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1652/console