Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: improve node:os userInfo performance #55719

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Nov 4, 2024

Improve node:os userInfo performance by reducing the cost of creating a v8::Object.

@anonrig anonrig requested a review from jasnell November 4, 2024 16:11
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. os Issues and PRs related to the os subsystem. labels Nov 4, 2024
@RedYetiDev RedYetiDev added the needs-benchmark-ci PR that need a benchmark CI run. label Nov 4, 2024
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.39%. Comparing base (bdc2662) to head (55614e5).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/node_os.cc 94.11% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #55719      +/-   ##
==========================================
+ Coverage   88.38%   88.39%   +0.01%     
==========================================
  Files         654      654              
  Lines      187575   187651      +76     
  Branches    36096    36110      +14     
==========================================
+ Hits       165795   165883      +88     
+ Misses      15004    14998       -6     
+ Partials     6776     6770       -6     
Files with missing lines Coverage Δ
lib/os.js 97.31% <ø> (-0.04%) ⬇️
src/node_os.cc 82.37% <94.11%> (+0.06%) ⬆️

... and 17 files with indirect coverage changes

@anonrig anonrig requested a review from ronag November 4, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. needs-benchmark-ci PR that need a benchmark CI run. needs-ci PRs that need a full CI run. os Issues and PRs related to the os subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants