zlib: deprecate classes usage without new
#55718
Open
+40
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
RedYetiDev
added
semver-major
|
The
notable-change
Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section. |
RedYetiDev
reviewed
Nov 4, 2024
anonrig
force-pushed
the
yagiz/deprecate-zlib
branch
from
f77caf7
to
dbfed33
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55718 +/- ##
==========================================
+ Coverage 88.38% 88.41% +0.02%
==========================================
Files 654 654
Lines 187575 187682 +107
Branches 36096 36110 +14
==========================================
+ Hits 165795 165941 +146
+ Misses 15004 14985 -19
+ Partials 6776 6756 -20
|
RedYetiDev
reviewed
Nov 4, 2024
Comment on lines
+690
to
+691
| process.emitWarning(`Instantiating Deflate class without 'new' is deprecated.`, | ||
| 'DeprecationWarning', 'DEP0184'); |
There was a problem hiding this comment.
FWIW when #54869 lands there will be a helper utility for this warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we documentation-only deprecated the usage without
newqualifier, we can make it runtime deprecated.