Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improve zlib tests #55716

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Nov 4, 2024

Remove several unnecessary zlib tests, and use node:test as much as we can. This also avoids calling require('../common') functionality as much as we can.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 4, 2024
@RedYetiDev RedYetiDev added the zlib Issues and PRs related to the zlib subsystem. label Nov 4, 2024
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.38%. Comparing base (5d4fee8) to head (e337280).
Report is 66 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #55716      +/-   ##
==========================================
- Coverage   88.42%   88.38%   -0.04%     
==========================================
  Files         654      654              
  Lines      187662   187575      -87     
  Branches    36118    36087      -31     
==========================================
- Hits       165945   165796     -149     
- Misses      14955    15019      +64     
+ Partials     6762     6760       -2     

see 77 files with indirect coverage changes

Copy link
Member

@lpinca lpinca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with removing redundant tests but I'm -1 on using node:test as much as we can as per #54796 and #55110 (review). In my opinion this is not an improvement, but added complexity and spurious code executed as part of the test, which could also affect the reliability of the test itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. zlib Issues and PRs related to the zlib subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants