Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: avoid excluding symlinks in recursive fs.readdir with filetypes #55714

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

juanarbol
Copy link
Member

Fixes: #52663

@nodejs-github-bot nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Nov 4, 2024
@juanarbol juanarbol added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 4, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 4, 2024
@nodejs-github-bot
Copy link
Collaborator

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.40%. Comparing base (32ff100) to head (33f31fe).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #55714   +/-   ##
=======================================
  Coverage   88.39%   88.40%           
=======================================
  Files         654      654           
  Lines      187560   187563    +3     
  Branches    36087    36082    -5     
=======================================
+ Hits       165800   165806    +6     
+ Misses      14996    14995    -1     
+ Partials     6764     6762    -2     
Files with missing lines Coverage Δ
lib/fs.js 98.15% <100.00%> (+<0.01%) ⬆️

... and 27 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

withFileTypes has different behavior in fs.readdir when reading symbolic directories
2 participants