test,crypto: update WebCryptoAPI WPT #55703
Merged
+98
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
needs-ci
panva
added
crypto
github-actions
bot
removed
the
request-ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55703 +/- ##
==========================================
- Coverage 88.41% 88.40% -0.02%
==========================================
Files 654 654
Lines 187594 187594
Branches 36090 36094 +4
==========================================
- Hits 165870 165835 -35
- Misses 14980 14997 +17
- Partials 6744 6762 +18 |
RedYetiDev
added
the
author ready
aduh95
approved these changes
Nov 3, 2024
Comment on lines
+293
to
+294
| if (byteValue == NaN) | ||
| throw "Invalid hexString"; |
There was a problem hiding this comment.
Probably not something for us to fix, but I don't think any value in JS can be loosely equal to NaN, this looks like dead code (reported in https://github.com/web-platform-tests/wpt/pull/48852/files#r1827029556)
lpinca
approved these changes
Nov 3, 2024
panva
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 58a7b00 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just
git node wpt WebCryptoAPI