build: add create release proposal action #55690
Conversation
|
Review requested:
|
nodejs-github-bot
added
meta
| env: | ||
| STAGING_BRANCH: v${{ inputs.release-line }}.x-staging | ||
| RELEASE_BRANCH: v${{ inputs.release-line }}.x | ||
| RELEASE_DATE: ${{ inputs.release-date }} |
There was a problem hiding this comment.
Can't you merge this with the env a few lines above?
| # Needs the whole git history for ncu to work | ||
| # See https://github.com/nodejs/node-core-utils/pull/486 | ||
| fetch-depth: 0 | ||
| token: ${{ secrets.GH_USER_TOKEN }} |
There was a problem hiding this comment.
This doesn't need the special token, it's only checking out a branch?
| - name: Set variables | ||
| run: | | ||
| echo "REPOSITORY=$(echo ${{ github.repository }} | cut -d/ -f2)" >> $GITHUB_ENV | ||
| echo "OWNER=${{ github.repository_owner }}" >> $GITHUB_ENV |
There was a problem hiding this comment.
Why not set this when the rest of the environment is set?
|
|
||
| - name: Set variables | ||
| run: | | ||
| echo "REPOSITORY=$(echo ${{ github.repository }} | cut -d/ -f2)" >> $GITHUB_ENV |
There was a problem hiding this comment.
You should probably store "github.repository" in an environment variable, IMO it's cleaner + it's best practice
|
|
||
| - name: Configure @node-core/utils | ||
| run: | | ||
| ncu-config set branch ${{ env.RELEASE_BRANCH }} |
There was a problem hiding this comment.
| ncu-config set branch ${{ env.RELEASE_BRANCH }} | |
| ncu-config set branch "${RELEASE_BRANCH}" |
| JENKINS_TOKEN: ${{ secrets.JENKINS_TOKEN }} | ||
|
|
||
| - name: Start git node release prepare | ||
| run: ./tools/actions/create-release.sh ${{ inputs.RELEASE_DATE }} |
There was a problem hiding this comment.
storing the input in an environment variable is best practice
| # We use it to not specify the branch name as it changes based on | ||
| # the commit list (semver-minor/semver-patch) | ||
| git config push.default current | ||
| git push upstream |
There was a problem hiding this comment.
We probably should not expect to have push permission, and instead make an API call to create the release commit using a createCommitOnBranch API call
Blocked until the following PR lands
Refs: nodejs/security-wg#860
The purpose is to have an action that will generate the release proposal (assuming the vN.x-staging is up to date). After that, I'll create a second action the keep the staging branches up-to-date.
cc: @nodejs/releasers