build: use rclone instead of aws CLI #55617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use rclone to upload assets to Cloudflare as it is more reliable. Refs: nodejs/build#3508
nodejs-github-bot
added
build
|
Draft because the server is not fully configured for it to work. /cc @nodejs/build-infra @flakey5 @ovflowd I'll undraft when nodejs/build#3945 is merged. |
richardlau
approved these changes
Oct 31, 2024
richardlau
added
lts-watch-v18.x
flakey5
approved these changes
Oct 31, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55617 +/- ##
==========================================
- Coverage 88.43% 88.43% -0.01%
==========================================
Files 654 654
Lines 187698 187729 +31
Branches 36126 36142 +16
==========================================
+ Hits 165986 166011 +25
+ Misses 14953 14947 -6
- Partials 6759 6771 +12 |
github-actions
bot
removed
the
request-ci
MoLow
approved these changes
Nov 1, 2024
targos
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in d37214b |
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
Use rclone to upload assets to Cloudflare as it is more reliable. Refs: nodejs/build#3508 PR-URL: nodejs#55617 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Nov 5, 2024
Use rclone to upload assets to Cloudflare as it is more reliable. Refs: nodejs/build#3508 PR-URL: #55617 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use rclone to upload assets to Cloudflare as it is more reliable.
Refs: nodejs/build#3508