src: refactor ECDHBitsJob signature #55610
Merged
+23
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
c++
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #55610 +/- ##
=======================================
Coverage 88.43% 88.44%
=======================================
Files 654 654
Lines 187699 187694 -5
Branches 36125 36123 -2
=======================================
+ Hits 165995 165997 +2
+ Misses 14948 14946 -2
+ Partials 6756 6751 -5
|
lpinca
approved these changes
Oct 31, 2024
panva
added
author ready
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
tniessen
approved these changes
Nov 2, 2024
panva
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 4bf5731 |
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
PR-URL: nodejs#55610 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Nov 5, 2024
PR-URL: #55610 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removes use of
GetOKPCurveFromNameinECDHBitsJoband movesGetOKPCurveFromNamecloser to its only remaining invocation.