Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util: don't catch on circular toStringTag error #55544

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

RedYetiDev
Copy link
Member

Fixes #55539 by only supressing an error from a circular inspectRaw if it is a max-call-stack-exceeded error, otherwise, throw the error.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module. labels Oct 26, 2024
@RedYetiDev RedYetiDev changed the title util: don't throw on circular toStringTag error util: don't catch on circular toStringTag error Oct 26, 2024
Copy link

codecov bot commented Oct 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.42%. Comparing base (53b1050) to head (e1669f2).
Report is 77 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main   #55544    +/-   ##
========================================
  Coverage   88.42%   88.42%            
========================================
  Files         654      654            
  Lines      187552   187659   +107     
  Branches    36087    36120    +33     
========================================
+ Hits       165839   165937    +98     
- Misses      14950    14960    +10     
+ Partials     6763     6762     -1     
Files with missing lines Coverage Δ
lib/internal/util/inspect.js 99.95% <100.00%> (-0.05%) ⬇️

... and 36 files with indirect coverage changes

@RedYetiDev RedYetiDev added the review wanted PRs that need reviews. label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. review wanted PRs that need reviews. util Issues and PRs related to the built-in util module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ERR_INTERNAL_ASSERTION from console.log(), TypeError: Converting circular structure to JSON
2 participants