src: move more key related stuff to ncrypto #55368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
lib / src
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
force-pushed
the
moar-ncrypto-key
branch
from
b9237ad
to
bf9673b
Compare
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
force-pushed
the
moar-ncrypto-key
branch
from
bf9673b
to
df1a9ea
Compare
This comment was marked as outdated.
This comment was marked as outdated.
anonrig
reviewed
Oct 12, 2024
RedYetiDev
added
crypto
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #55368 +/- ##
=======================================
Coverage 88.40% 88.40%
=======================================
Files 652 652
Lines 186777 186687 -90
Branches 36047 36028 -19
=======================================
- Hits 165111 165049 -62
+ Misses 14919 14904 -15
+ Partials 6747 6734 -13
|
anonrig
approved these changes
Oct 13, 2024
jasnell
added
author ready
nodejs-github-bot
removed
the
commit-queue
Commit Queue failed- Loading data for nodejs/node/pull/55368 ✔ Done loading data for nodejs/node/pull/55368 ----------------------------------- PR info ------------------------------------ Title src: move more key related stuff to ncrypto (#55368) Author James M Snell <[email protected]> (@jasnell) Branch jasnell:moar-ncrypto-key -> nodejs:main Labels crypto, author ready, needs-ci, dependencies Commits 1 - src: move more key related stuff to ncrypto Committers 1 - James M Snell <[email protected]> PR-URL: https://github.com/nodejs/node/pull/55368 Reviewed-By: Yagiz Nizipli <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/55368 Reviewed-By: Yagiz Nizipli <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 12 Oct 2024 22:08:47 GMT ✔ Approvals: 1 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/55368#pullrequestreview-2364968879 ✘ This PR needs to wait 119 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-10-13T16:24:45Z: https://ci.nodejs.org/job/node-test-pull-request/63082/ - Querying data for job/node-test-pull-request/63082/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/11335810282 |
nodejs-github-bot
added
the
commit-queue-failed
marco-ippolito
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 5b9bf39 |
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
PR-URL: nodejs#55368 Reviewed-By: Yagiz Nizipli <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Nov 5, 2024
PR-URL: #55368 Reviewed-By: Yagiz Nizipli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.