build: apply cpp linting and formatting to ncrypto #55362
+435
−340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
build
|
CC @nodejs/crypto |
|
Oh nice. Thank you. I've been meaning to get to this. Very helpful |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55362 +/- ##
==========================================
- Coverage 88.40% 87.91% -0.50%
==========================================
Files 654 654
Lines 187637 187655 +18
Branches 36098 35803 -295
==========================================
- Hits 165887 164977 -910
- Misses 14994 15877 +883
- Partials 6756 6801 +45 |
jasnell
approved these changes
Oct 11, 2024
|
btw, the intention is to move ncrypto out to a separate repo once all of the work is done to separate it out. It'll be a while tho. At that time that separate project will have its own build and linting stuff |
RedYetiDev
added
author ready
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
|
Hey, can someone restart the failed builds so this fix can land? Thanks! |
RedYetiDev
force-pushed
the
lint-ncrypto
branch
from
c48c984
to
bb8a7d2
Compare
|
@jasnell would you mind re-approving + CI-ing now that a new commit has been added? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC @jasnell (who appears to have contributed most of this work)
If these files are maintained in this repository, should they not follow the same linting / formatting rules? This PR has
clang-formatandcpplintapply to these files.