fix async context frame test when tests are run with --shell option #55185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
|
Is this meant for main or v22? Just making sure... |
Forward execPath as test.py --shell so subprocess tests run with the same executable as the parent test. Otherwise tests are broken if out/Debug/node doesn't exist or is a different executble than the caller intended.
everett1992
force-pushed
the
test-async-local-storage-fix
branch
from
3acc916
to
ec16960
Compare
|
Should probably be main, I think my fork was outdated and I saw merge conflicts and 1.2k commits between this change and main. |
RedYetiDev
removed
the
v22.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I run node's unit tests with the
--shelloption to test an executable that isn't inout/Debug/node. The test-async-local-storage tests fail because they call test.py again, but without forwarding the --shell argument and test.py fails to find the vm/shell to spawn.With this change we set the shell option so the spawned tests run with the same node executable as the parent test.
I wonder if passing thru test.py is required tho? Why doesn't this fork and run the
testfile with additional arguments?