Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util: runtime deprecate toUSVString() #55018

Closed
wants to merge 1 commit into from

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Sep 19, 2024

Let's runtime deprecate toUSVString()

cc @nodejs/tsc

@anonrig anonrig added the semver-major PRs that contain breaking changes and should be released in the next major version. label Sep 19, 2024
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module. labels Sep 19, 2024
@anonrig anonrig force-pushed the runtime-deprecate-tousvstring branch from c69bb5e to 962ea51 Compare September 19, 2024 19:45
Copy link
Member

@marco-ippolito marco-ippolito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually add a test to check warning is emitted

@RafaelGSS RafaelGSS added the deprecations Issues and PRs related to deprecations. label Sep 19, 2024
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide some context on why we are deprecating it? It's useful for users that will read the v23 changelog.

@benjamingr
Copy link
Member

Don't we also need to update the docs?

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.04%. Comparing base (291d90a) to head (962ea51).
Report is 270 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #55018   +/-   ##
=======================================
  Coverage   88.04%   88.04%           
=======================================
  Files         652      652           
  Lines      183764   183767    +3     
  Branches    35862    35862           
=======================================
+ Hits       161787   161798   +11     
+ Misses      15233    15223   -10     
- Partials     6744     6746    +2     
Files with missing lines Coverage Δ
lib/util.js 96.96% <100.00%> (+0.02%) ⬆️

... and 28 files with indirect coverage changes

@mcollina
Copy link
Member

I think this will result in a lot of warning on unmaintained modules. What cost is there in keeping this?

@anonrig
Copy link
Member Author

anonrig commented Oct 18, 2024

I think this will result in a lot of warning on unmaintained modules. What cost is there in keeping this?

Cost of keeping

@anonrig anonrig closed this Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecations Issues and PRs related to deprecations. needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version. util Issues and PRs related to the built-in util module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants