v8,tools: expose experimental wasm revectorize feature #54896
+19
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
build
targos
reviewed
Sep 12, 2024
yolanda15
force-pushed
the
enable_revec
branch
from
07ba285
to
f5381ba
Compare
targos
approved these changes
Sep 13, 2024
|
@targos Could you help me merge this PL? I seem not authorized and it's already one week passed. Thank you in advance! |
gengjiawen
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/54896 ✔ Done loading data for nodejs/node/pull/54896 ----------------------------------- PR info ------------------------------------ Title v8,tools: expose experimental wasm revectorize feature (#54896) Author Yolanda-Chen <[email protected]> (@yolanda15, first-time contributor) Branch yolanda15:enable_revec -> nodejs:main Labels build, v8 engine, tools, needs-ci Commits 1 - v8,tools: expose experimental wasm revectorize feature Committers 1 - Yolanda Chen <[email protected]> PR-URL: https://github.com/nodejs/node/pull/54896 Reviewed-By: Michaël Zasso <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/54896 Reviewed-By: Michaël Zasso <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 12 Sep 2024 07:48:42 GMT ✔ Approvals: 1 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/54896#pullrequestreview-2303482481 ✔ Last GitHub CI successful ✘ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/10952384360 |
yolanda15
force-pushed
the
enable_revec
branch
from
f5381ba
to
8234dfd
Compare
jasnell
approved these changes
Sep 21, 2024
yolanda15
force-pushed
the
enable_revec
branch
from
0e46290
to
7db8179
Compare
|
The test failure seems unrelated. Not wasm test and not reproducible locally. Rebased and rerun the test. |
yolanda15
force-pushed
the
enable_revec
branch
from
7db8179
to
f3f3245
Compare
|
Rebase again. Could anyone help approve the workflows? |
RedYetiDev
removed
the
commit-queue-failed
|
Seems all test passed. I'm still not authorized. Could anyone help merge this PR? Not sure if any other authority is needed. Thanks in advance! |
marco-ippolito
added
request-ci
github-actions
bot
removed
the
request-ci
yolanda15
force-pushed
the
enable_revec
branch
from
f3f3245
to
f9f09d7
Compare
|
Thanks Marco! Rebased to avoid test failures. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wasm simd256 revectorization feature is enabled by default when v8_enable_webassembly is true on x64 target in V8. At runtime it will be enabled through flag --experimental-wasm-revectorize.
This PR adds the build configuration in Node to enable this feature and make it explicitly accessible through the same runtime flag for x64 build.