Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: update error message for ICU in license-builder #54742

Closed
wants to merge 1 commit into from
Closed

tools: update error message for ICU in license-builder #54742

wants to merge 1 commit into from

Conversation

RedYetiDev
Copy link
Member 

(Old) ICU not installed, run configure to download it, e.g. ./configure --with-intl=small-icu --download=icu

(New) ICU not installed, run `./configure --with-intl=small-icu --download=icu` to download it.

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Sep 3, 2024
@srl295 srl295 added i18n-api Issues and PRs related to the i18n implementation. icu Issues and PRs related to the ICU dependency. labels Sep 6, 2024
@RedYetiDev
Copy link
Member Author

@jasnell @srl295 can this land?

@RedYetiDev RedYetiDev added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 19, 2024
jasnell pushed a commit that referenced this pull request Sep 21, 2024
@RedYetiDev @jasnell
tools: update error message for ICU in license-builder
6a52e81 
PR-URL: #54742
Reviewed-By: Steven R Loomis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

jasnell commented Sep 21, 2024

Landed in 6a52e81

@jasnell jasnell closed this Sep 21, 2024
targos pushed a commit that referenced this pull request Oct 4, 2024
@RedYetiDev @targos
tools: update error message for ICU in license-builder
295f684 
PR-URL: #54742
Reviewed-By: Steven R Loomis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@aduh95 aduh95 mentioned this pull request Oct 9, 2024
Merged
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
@RedYetiDev @louwers
tools: update error message for ICU in license-builder
671567d 
PR-URL: nodejs#54742
Reviewed-By: Steven R Loomis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@srl295 srl295 srl295 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. i18n-api Issues and PRs related to the i18n implementation. icu Issues and PRs related to the ICU dependency. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RedYetiDev @jasnell @srl295 @nodejs-github-bot