Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: respect dereference when copy symlink directory #54732

Merged
merged 1 commit into from
Sep 5, 2024
Merged

fs: respect dereference when copy symlink directory #54732

merged 1 commit into from
Sep 5, 2024

Conversation

jazelly
Copy link
Member

@jazelly jazelly commented Sep 3, 2024

Fixes: #54730

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Sep 3, 2024
@jazelly jazelly marked this pull request as draft September 3, 2024 13:51
@jazelly jazelly marked this pull request as ready for review September 3, 2024 14:09
@anonrig anonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 3, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 3, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@codecov Codecov
Copy link

codecov bot commented Sep 3, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.61%. Comparing base (298dea0) to head (79ef70a).
Report is 250 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #54732   +/-   ##
=======================================
  Coverage   87.61%   87.61%           
=======================================
  Files         650      650           
  Lines      182829   182831    +2     
  Branches    35382    35381    -1     
=======================================
+ Hits       160179   160185    +6     
+ Misses      15931    15925    -6     
- Partials     6719     6721    +2
Files with missing lines Coverage Δ
src/node_file.cc 76.94% <100.00%> (-0.03%) ⬇️

... and 32 files with indirect coverage changes

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@jakecastelli jakecastelli added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 4, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 4, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 4, 2024 •
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/61922/ 💛

@anonrig anonrig requested a review from jasnell September 4, 2024 23:33
@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 5, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 5, 2024
@nodejs-github-bot nodejs-github-bot merged commit a48852b into nodejs:main Sep 5, 2024
84 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in a48852b

aduh95 pushed a commit that referenced this pull request Sep 12, 2024
@jazelly @jakecastelli @aduh95
fs: respect dereference when copy symlink directory
ee89c31 
Co-authored-by: Jake Yuesong Li <[email protected]>
PR-URL: #54732
Fixes: #54730
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Sep 16, 2024
Merged
@targos targos added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Sep 22, 2024
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
@jazelly @jakecastelli @louwers
fs: respect dereference when copy symlink directory
cb737c0 
Co-authored-by: Jake Yuesong Li <[email protected]>
PR-URL: nodejs#54732
Fixes: nodejs#54730
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@anonrig anonrig anonrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cpSync symlink handling regression
6 participants
@jazelly @nodejs-github-bot @jasnell @anonrig @targos @jakecastelli