deps: allow amaro to be externalizable #54646

mhdawson · 2024-08-29T20:22:48Z

allow amaro to be externalized like other builtins containing WASM. More context is available in https://github.com/nodejs/node/blob/main/doc/contributing/maintaining/maintaining-dependencies.md#supporting-externalizable-dependencies-with-javascript-code

- allow amaro to be externalized like other builtins containing WASM. More context is available in https://github.com/nodejs/node/blob/main/doc/contributing/maintaining/maintaining-dependencies.md#supporting-externalizable-dependencies-with-javascript-code Signed-off-by: Michael Dawson <[email protected]>

nodejs-github-bot · 2024-08-29T20:22:53Z

Review requested:

@nodejs/gyp
@nodejs/startup

mhdawson · 2024-08-29T20:23:47Z

FYI @marco-ippolito

codecov · 2024-08-29T21:52:01Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.61%. Comparing base (fc02b88) to head (865ac33).
Report is 283 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #54646      +/-   ##
==========================================
+ Coverage   87.30%   87.61%   +0.30%     
==========================================
  Files         649      650       +1     
  Lines      182755   182829      +74     
  Branches    35044    35384     +340     
==========================================
+ Hits       159552   160181     +629     
+ Misses      16466    15919     -547     
+ Partials     6737     6729       -8

Files with missing lines	Coverage Δ
src/node_builtins.cc	`78.43% <ø> (-0.24%)`	⬇️
src/node_metadata.cc	`91.66% <ø> (ø)`

... and 74 files with indirect coverage changes

nodejs-github-bot · 2024-08-30T13:41:44Z

CI: https://ci.nodejs.org/job/node-test-pull-request/61708/

richardlau · 2024-08-30T14:57:13Z

FWIW process.versions is wrong if using externalized amaro -- it will print 0.1.8 from

node/src/amaro_version.h

Line 5 in 5a22d8e

#define AMARO_VERSION "0.1.8"

regardless of whatever version the externalized amaro is. Compare with, e.g. undici where if an externalized version is used it is omitted from process.versions:

node/src/node_metadata.cc

Lines 122 to 124 in 5a22d8e

    
           #ifndef NODE_SHARED_BUILTIN_UNDICI_UNDICI_PATH 
        
             undici = UNDICI_VERSION; 
        
           #endif

src/node_builtins.cc

Co-authored-by: Luigi Pinca <[email protected]>

Signed-off-by: Michael Dawson <[email protected]>

mhdawson · 2024-09-03T15:26:28Z

@richardlau added the guard for process.versions.

nodejs-github-bot · 2024-09-03T15:37:39Z

CI: https://ci.nodejs.org/job/node-test-pull-request/61865/

src/node_metadata.cc

Signed-off-by: Michael Dawson <[email protected]>

nodejs-github-bot · 2024-09-03T19:38:03Z

CI: https://ci.nodejs.org/job/node-test-pull-request/61880/

src/node_metadata.h

Co-authored-by: Chengzhong Wu <[email protected]>

nodejs-github-bot · 2024-09-04T13:31:32Z

CI: https://ci.nodejs.org/job/node-test-pull-request/61920/

nodejs-github-bot · 2024-09-05T00:36:04Z

CI: https://ci.nodejs.org/job/node-test-pull-request/61960/

nodejs-github-bot · 2024-09-05T16:26:05Z

CI: https://ci.nodejs.org/job/node-test-pull-request/62000/

Refs: nodejs#54646 - Add instructions to update how process.versions is reported as I missed that in a recent addition. Signed-off-by: Michael Dawson <[email protected]>

- allow amaro to be externalized like other builtins containing WASM. More context is available in https://github.com/nodejs/node/blob/main/doc/contributing/maintaining/maintaining-dependencies.md#supporting-externalizable-dependencies-with-javascript-code Signed-off-by: Michael Dawson <[email protected]> PR-URL: #54646 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: James M Snell <[email protected]>

mhdawson · 2024-09-05T18:28:25Z

Landed in ce19715

- allow amaro to be externalized like other builtins containing WASM. More context is available in https://github.com/nodejs/node/blob/main/doc/contributing/maintaining/maintaining-dependencies.md#supporting-externalizable-dependencies-with-javascript-code Signed-off-by: Michael Dawson <[email protected]> PR-URL: #54646 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: James M Snell <[email protected]>

Refs: #54646 - Add instructions to update how process.versions is reported as I missed that in a recent addition. Signed-off-by: Michael Dawson <[email protected]> PR-URL: #54792 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Akhil Marsonya <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Ulises Gascón <[email protected]>

- allow amaro to be externalized like other builtins containing WASM. More context is available in https://github.com/nodejs/node/blob/main/doc/contributing/maintaining/maintaining-dependencies.md#supporting-externalizable-dependencies-with-javascript-code Signed-off-by: Michael Dawson <[email protected]> PR-URL: nodejs#54646 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: James M Snell <[email protected]>

Refs: nodejs#54646 - Add instructions to update how process.versions is reported as I missed that in a recent addition. Signed-off-by: Michael Dawson <[email protected]> PR-URL: nodejs#54792 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Akhil Marsonya <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Ulises Gascón <[email protected]>

nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Aug 29, 2024

RedYetiDev added the strip-types Issues or PRs related to strip-types support label Aug 29, 2024

marco-ippolito approved these changes Aug 30, 2024

View reviewed changes

mhdawson added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 30, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 30, 2024

aymen94 approved these changes Aug 30, 2024

View reviewed changes

richardlau approved these changes Aug 30, 2024

View reviewed changes

lpinca approved these changes Aug 31, 2024

View reviewed changes

src/node_builtins.cc Outdated Show resolved Hide resolved

mhdawson and others added 2 commits September 3, 2024 11:01

Update src/node_builtins.cc

a276828

Co-authored-by: Luigi Pinca <[email protected]>

squash: address review comments

70154e9

Signed-off-by: Michael Dawson <[email protected]>

mhdawson added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 3, 2024

richardlau approved these changes Sep 3, 2024

View reviewed changes

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 3, 2024

legendecas reviewed Sep 3, 2024

View reviewed changes

src/node_metadata.cc Show resolved Hide resolved

squash: address comments

3e9f641

Signed-off-by: Michael Dawson <[email protected]>

mhdawson added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 3, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 3, 2024

legendecas reviewed Sep 3, 2024

View reviewed changes

src/node_metadata.h Outdated Show resolved Hide resolved

Update src/node_metadata.h

865ac33

Co-authored-by: Chengzhong Wu <[email protected]>

richardlau added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Sep 4, 2024

mhdawson added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 4, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 4, 2024

legendecas approved these changes Sep 4, 2024

View reviewed changes

jasnell approved these changes Sep 5, 2024

View reviewed changes

mhdawson mentioned this pull request Sep 5, 2024

doc: update documentation for externalizing deps #54792

Closed

mhdawson closed this Sep 5, 2024

RafaelGSS mentioned this pull request Sep 16, 2024

v22.9.0 proposal #54966

Merged

targos added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Sep 22, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

deps: allow amaro to be externalizable #54646

deps: allow amaro to be externalizable #54646

mhdawson commented Aug 29, 2024

nodejs-github-bot commented Aug 29, 2024

mhdawson commented Aug 29, 2024

codecov bot commented Aug 29, 2024 •

edited

Loading

nodejs-github-bot commented Aug 30, 2024

richardlau commented Aug 30, 2024

mhdawson commented Sep 3, 2024

nodejs-github-bot commented Sep 3, 2024

nodejs-github-bot commented Sep 3, 2024

nodejs-github-bot commented Sep 4, 2024

nodejs-github-bot commented Sep 5, 2024

nodejs-github-bot commented Sep 5, 2024

mhdawson commented Sep 5, 2024

deps: allow amaro to be externalizable #54646

deps: allow amaro to be externalizable #54646

Conversation

mhdawson commented Aug 29, 2024

nodejs-github-bot commented Aug 29, 2024

mhdawson commented Aug 29, 2024

codecov bot commented Aug 29, 2024 • edited Loading

Codecov Report

nodejs-github-bot commented Aug 30, 2024

richardlau commented Aug 30, 2024

mhdawson commented Sep 3, 2024

nodejs-github-bot commented Sep 3, 2024

nodejs-github-bot commented Sep 3, 2024

nodejs-github-bot commented Sep 4, 2024

nodejs-github-bot commented Sep 5, 2024

nodejs-github-bot commented Sep 5, 2024

mhdawson commented Sep 5, 2024

codecov bot commented Aug 29, 2024 •

edited

Loading