Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update V8 to 12.9 #54536

Closed
wants to merge 13 commits into from
Closed

deps: update V8 to 12.9 #54536

wants to merge 13 commits into from

Commits on Sep 17, 2024

  1. deps: update V8 to 12.9.202.18

    targos committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    b4cd81b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    013f7d8 View commit details
    Browse the repository at this point in the history
  3. src: update NODE_MODULE_VERSION to 131

    Major V8 updates are usually API/ABI incompatible with previous
    versions. This commit adapts NODE_MODULE_VERSION for V8 12.9.
    
    Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md
    targos committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    40113d1 View commit details
    Browse the repository at this point in the history
  4. deps: always define V8_EXPORT_PRIVATE as no-op

    dllexport introduces issues when compiling with MSVC.
    
    PR-URL: nodejs#47251
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Jiawen Geng <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    targos committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    affda4e View commit details
    Browse the repository at this point in the history
  5. deps: disable V8 concurrent sparkplug compilation

    It introduces process hangs on some platforms because Node.js doesn't
    tear down V8 correctly.
    Disable it while we work on a solution.
    
    Refs: nodejs#47297
    Refs: https://bugs.chromium.org/p/v8/issues/detail?id=13902
    PR-URL: nodejs#47450
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    targos committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    ddf2ae4 View commit details
    Browse the repository at this point in the history
  6. deps: patch V8 to avoid duplicated zlib symbol

    PR-URL: nodejs#54077
    Reviewed-By: Jiawen Geng <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Joyee Cheung <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    targos committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    d9b1876 View commit details
    Browse the repository at this point in the history
  7. deps: patch V8 to support compilation with MSVC

    Co-Authored-By: Michaël Zasso <[email protected]>
    StefanStojanovic and targos committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    763a6b9 View commit details
    Browse the repository at this point in the history
  8. deps: fix FP16 bitcasts.h

    PR-URL: nodejs#53134
    Refs: nodejs#52809
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    StefanStojanovic authored and targos committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    4d662bb View commit details
    Browse the repository at this point in the history
  9. deps: always define V8_NODISCARD as no-op

    It's causing compiler errors with some classes on Xcode 11
    and the attribute should have no runtime effect.
    
    PR-URL: nodejs#54077
    Reviewed-By: Jiawen Geng <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Joyee Cheung <[email protected]>
    Reviewed-By: Marco Ippolito <[email protected]>
    targos committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    4e012d4 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    f00716f View commit details
    Browse the repository at this point in the history
  11. deps: V8: cherry-pick 01a47f3ffff2

    Original commit message:
    
        [cfi] Add missing 'typename' in SegmentedTable
    
        Makes the code more consistent and fixes compilation on older Clang
        versions.
    
        Change-Id: I82abebd500e6651ac5c5b180cd7b49b4f20e8299
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5805956
        Reviewed-by: Samuel Groß <[email protected]>
        Commit-Queue: Michaël Zasso <[email protected]>
        Reviewed-by: Stephen Röttger <[email protected]>
        Cr-Commit-Position: refs/heads/main@{#95809}
    
    Refs: v8/v8@01a47f3
    targos committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    d2250da View commit details
    Browse the repository at this point in the history
  12. deps: V8: cherry-pick 97199f686e2f

    Original commit message:
    
        aix: add work around for f16 type
    
        AIX builds started to fail after this commit https://chromium.googlesource.com/v8/v8.git/+/d057564707d3a5df074b7f49a12a2f1e96638f94.
    
        Change-Id: I25a5c4ae3b4fe5c27a9fb9e35e2bcd2bbed40351
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5789180
        Reviewed-by: Clemens Backes <[email protected]>
        Reviewed-by: Nico Hartmann <[email protected]>
        Commit-Queue: Clemens Backes <[email protected]>
        Cr-Commit-Position: refs/heads/main@{#95952}
    
    Refs: v8/v8@97199f6
    targos committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    d174634 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. tools: add additonal include dirs for V8 on AIX

    On AIX, we now include src/wasm/float16.h from within src/utils/utils.h
    and src/wasm/float16.h includes additional header files.
    abmusse authored and targos committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    5e31092 View commit details
    Browse the repository at this point in the history