Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: prevent V8 from writing into the system's tmpdir #54395

Merged
merged 1 commit into from
Aug 21, 2024
Merged

test: prevent V8 from writing into the system's tmpdir #54395

merged 1 commit into from
Aug 21, 2024
+6 −1

Conversation

targos
Copy link
Member

@targos targos commented Aug 15, 2024

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Aug 15, 2024
@targos targos mentioned this pull request Aug 15, 2024
Open
@codecov Codecov
Copy link

codecov bot commented Aug 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.07%. Comparing base (2c14615) to head (530cf19).
Report is 381 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #54395      +/-   ##
==========================================
- Coverage   87.08%   87.07%   -0.01%     
==========================================
  Files         648      648              
  Lines      182341   182341              
  Branches    34982    34985       +3     
==========================================
- Hits       158783   158782       -1     
+ Misses      16831    16826       -5     
- Partials     6727     6733       +6

see 32 files with indirect coverage changes

@jakecastelli jakecastelli added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 16, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 16, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61162/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61178/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61181/

@jakecastelli
Copy link
Member 

19:18:58 FATAL: Unable to produce a script file
19:18:58 java.io.IOException: No space left on device
19:18:58 	at java.base/java.io.UnixFileSystem.createFileExclusively(Native Method)
19:18:58 	at java.base/java.io.File.createTempFile(File.java:2170)
19:18:58 	at hudson.FilePath$CreateTextTempFile.invoke(FilePath.java:1688)

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61256/

@jakecastelli jakecastelli added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 21, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 21, 2024
@nodejs-github-bot nodejs-github-bot merged commit 612e457 into nodejs:main Aug 21, 2024
55 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 612e457

@targos targos deleted the fix-test-tmp branch August 24, 2024 05:47
RafaelGSS pushed a commit that referenced this pull request Aug 25, 2024
@targos @RafaelGSS
test: prevent V8 from writing into the system's tmpdir
6a669cd 
Refs: nodejs/build#3864
PR-URL: #54395
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Aug 25, 2024
Merged
RafaelGSS pushed a commit that referenced this pull request Aug 30, 2024
@targos @RafaelGSS
test: prevent V8 from writing into the system's tmpdir
b0ed8db 
Refs: nodejs/build#3864
PR-URL: #54395
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@targos targos added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@anonrig anonrig anonrig approved these changes

@richardlau richardlau richardlau approved these changes

@juanarbol juanarbol juanarbol approved these changes

@jakecastelli jakecastelli jakecastelli approved these changes

Assignees
No one assigned
Labels
dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@targos @nodejs-github-bot @jakecastelli @lpinca @anonrig @richardlau @juanarbol