Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta: remove unneeded ignore rules from ruff #54360

Merged
merged 2 commits into from
Sep 18, 2024
Merged

meta: remove unneeded ignore rules from ruff #54360

merged 2 commits into from
Sep 18, 2024

Conversation

RedYetiDev
Copy link
Member

Ruff doesn't need these ignore rules, as the files are not breaking them. Additionally, these files should be placed under the exclude section, as they are updated automatically via the dependency updaters, rather than via manual editing.

$ make lint-py      
tools/pip/site-packages/bin/ruff --version
ruff 0.5.2
tools/pip/site-packages/bin/ruff check .
All checks passed!

@RedYetiDev RedYetiDev added the python PRs and issues that require attention from people who are familiar with Python. label Aug 13, 2024
targos
targos reviewed Aug 14, 2024
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
@RedYetiDev RedYetiDev requested a review from targos August 14, 2024 18:13
@RedYetiDev RedYetiDev added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Aug 14, 2024
@targos
Copy link
Member

targos commented Aug 16, 2024

@nodejs/python

cclauss
cclauss reviewed Aug 16, 2024
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
@RedYetiDev @cclauss
Update pyproject.toml
e17556a 
Co-authored-by: Christian Clauss <[email protected]>
@RedYetiDev
Copy link
Member Author

author ready?

@cclauss
Copy link
Contributor

cclauss commented Aug 22, 2024

Can someone please rectify the Merging is blocked message below?

@RedYetiDev
Copy link
Member Author

Can someone please rectify the Merging is blocked message below?

I only see merging is blocked because I'm not authorized, is it blocked for another reason?

@RedYetiDev
Copy link
Member Author

RedYetiDev commented Aug 29, 2024 •
edited
Loading

No objections in a few weeks, author ready? WDYT?

@jasnell jasnell added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 8, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 8, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62172/

@RedYetiDev
Copy link
Member Author

CI LGTM

@RedYetiDev
Copy link
Member Author

Can this land?

@RedYetiDev RedYetiDev added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 18, 2024
@aduh95 aduh95 merged commit c6ae161 into nodejs:main Sep 18, 2024
50 of 52 checks passed
@aduh95
Copy link
Contributor

aduh95 commented Sep 18, 2024

Landed in c6ae161

targos pushed a commit that referenced this pull request Oct 4, 2024
@RedYetiDev @targos
meta: remove unneeded ignore rules from ruff
e1f36d0 
PR-URL: #54360
Reviewed-By: Christian Clauss <[email protected]>
@aduh95 aduh95 mentioned this pull request Oct 9, 2024
Merged
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
@RedYetiDev @louwers
meta: remove unneeded ignore rules from ruff
14029ad 
PR-URL: nodejs#54360
Reviewed-By: Christian Clauss <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

@targos targos Awaiting requested review from targos

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. python PRs and issues that require attention from people who are familiar with Python.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@RedYetiDev @targos @cclauss @nodejs-github-bot @aduh95 @jasnell