Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: update doc to new version #51192

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot commented Dec 17, 2023

This is an automated update of doc to new version.

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Dec 17, 2023
@nodejs-github-bot
Copy link
Collaborator Author

Review requested:

  • @nodejs/web-infra

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Dec 17, 2023
@marco-ippolito
Copy link
Member

I think this update should be split into several commits to prevent commit message lint failure

@aduh95 aduh95 added the blocked PRs that are blocked by other issues or PRs. label Dec 17, 2023
@aduh95
Copy link
Contributor

aduh95 commented Dec 17, 2023

This is blocked by micromark/micromark#157, see #49988 (comment)

@aduh95 aduh95 added the needs-ci PRs that need a full CI run. label Feb 11, 2024
@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 21, 2024
@MoLow
Copy link
Member

MoLow commented Apr 21, 2024

running a full CI cycle to check if this can get unblocked

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 21, 2024
@nodejs-github-bot
Copy link
Collaborator Author

@MoLow
Copy link
Member

MoLow commented Apr 21, 2024

still failing

10:25:08 export const unicodePunctuation = regexCheck(/\p{P}|\p{S}/u);
10:25:08                                              ^^^^^^^^^^^^^^
10:25:08 
10:25:08 SyntaxError: Invalid regular expression: /\p{P}|\p{S}/u: Invalid property name
10:25:08     at compileSourceTextModule (node:internal/modules/esm/utils:337:16)
10:25:08     at ModuleLoader.moduleStrategy (node:internal/modules/esm/translators:168:18)
10:25:08     at callTranslator (node:internal/modules/esm/loader:428:14)
10:25:08     at ModuleLoader.moduleProvider (node:internal/modules/esm/loader:434:30)

@marco-ippolito
Copy link
Member

amended commit otherwise we will never land this, I'll fix the tool in another PR

@nodejs-github-bot nodejs-github-bot changed the title tools: update doc to [email protected] [email protected] [email protected] [email protected] [email protected] tools: update doc to new version May 12, 2024
@RedYetiDev RedYetiDev removed the blocked PRs that are blocked by other issues or PRs. label Sep 24, 2024
@RedYetiDev
Copy link
Member

(The blocking PR has been closed)

@aduh95 aduh95 added the blocked PRs that are blocked by other issues or PRs. label Sep 24, 2024
@aduh95
Copy link
Contributor

aduh95 commented Sep 24, 2024

(The blocking PR has been closed)

And the problem hasn't been addressed, the CI doesn't pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked PRs that are blocked by other issues or PRs. doc Issues and PRs related to the documentations. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants