Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: runtime deprecate fs.F_OK, fs.R_OK, fs.W_OK, fs.X_OK #49686

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fs: runtime deprecate fs.F_OK, fs.R_OK, fs.W_OK, fs.X_OK #49686

wants to merge 2 commits into from

Conversation

LiviaMedeiros
Copy link
Contributor

@LiviaMedeiros LiviaMedeiros commented Sep 17, 2023 •
edited
Loading

Follow-up from: #49683 (doc-only deprecation)

Opening this ahead of time to point out that the getters here are non-enumerable.

cc @nodejs/fs

@nodejs-github-bot nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Sep 17, 2023
@aduh95 aduh95 added the semver-major PRs that contain breaking changes and should be released in the next major version. label Sep 18, 2023
@LiviaMedeiros LiviaMedeiros added the blocked PRs that are blocked by other issues or PRs. label Sep 20, 2023
@LiviaMedeiros LiviaMedeiros marked this pull request as ready for review September 20, 2023 07:15
@LiviaMedeiros LiviaMedeiros added deprecations Issues and PRs related to deprecations. and removed blocked PRs that are blocked by other issues or PRs. labels Sep 25, 2023
@LiviaMedeiros LiviaMedeiros force-pushed the fs-runtime-deprecate-moisting-constants branch from 7a9498e to 956fcf1 Compare September 25, 2023 15:22
@richardlau
Copy link
Member

Given that we've only just doc-deprecated these #49683 (not in a release yet) I think it would be premature to runtime deprecate in Node.js 21. I'd have no objections to runtime deprecation in Node.js 22.

@LiviaMedeiros
Copy link
Contributor Author

Sure; converting back to draft until v21.x is released.

The main point of opening it now was to see if there are any objections or suggestions to the implementation.
If we keep the getters with enumerable: true, the deprecation warning will be indirectly triggered by child_process; I don't know if there is any better workaround.

@LiviaMedeiros LiviaMedeiros marked this pull request as draft September 25, 2023 17:50
@LiviaMedeiros LiviaMedeiros marked this pull request as ready for review November 18, 2023 19:10
@LiviaMedeiros LiviaMedeiros force-pushed the fs-runtime-deprecate-moisting-constants branch 2 times, most recently from be1b1c3 to c865ced Compare February 26, 2024 10:49
@LiviaMedeiros LiviaMedeiros added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 26, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 26, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57454/

@juanarbol
Copy link
Member

@LiviaMedeiros this may needs rebase, this is a good timing for v24.x I think (?)

@LiviaMedeiros LiviaMedeiros force-pushed the fs-runtime-deprecate-moisting-constants branch from c865ced to d5b465c Compare November 3, 2024 05:28
@LiviaMedeiros LiviaMedeiros added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Nov 3, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63401/

@LiviaMedeiros
Copy link
Contributor Author

Rebased on main.

cc @nodejs/tsc since it's semver-major PRs that contain breaking changes and should be released in the next major version.

@codecov Codecov
Copy link

codecov bot commented Nov 3, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 91.11111% with 4 lines in your changes missing coverage. Please review.

Project coverage is 88.39%. Comparing base (c2ff449) to head (5369c71).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
lib/fs.js 91.11% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #49686      +/-   ##
==========================================
- Coverage   88.41%   88.39%   -0.03%     
==========================================
  Files         654      654              
  Lines      187594   187635      +41     
  Branches    36090    36090              
==========================================
- Hits       165870   165867       -3     
- Misses      14980    15005      +25     
- Partials     6744     6763      +19
Files with missing lines Coverage Δ
lib/fs.js 98.14% <91.11%> (-0.01%) ⬇️

... and 28 files with indirect coverage changes

@aduh95
Copy link
Contributor

aduh95 commented Nov 3, 2024 •
edited
Loading

CITGM (main): https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3499/
CITGM (this PR): https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3500/

No related failure AFAICT

@LiviaMedeiros LiviaMedeiros added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 4, 2024
RafaelGSS
RafaelGSS reviewed Nov 4, 2024
View reviewed changes
lib/fs.js
@@ -3274,10 +3275,50 @@ defineLazyProperties(
);

ObjectDefineProperties(fs, {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have a test for it? We usually do something like https://github.com/nodejs/node/pull/55175/files#diff-4f2fa7a6febf9021fb93df3ec31e51b3bcbfb232a2b42bab8a1f7b496700646eR10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RafaelGSS RafaelGSS RafaelGSS left review comments

@aduh95 aduh95 aduh95 approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. deprecations Issues and PRs related to deprecations. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@LiviaMedeiros @richardlau @nodejs-github-bot @juanarbol @aduh95 @RafaelGSS @marco-ippolito