deps: update V8 to 11.5 #48456
Closed
deps: update V8 to 11.5 #48456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
build
|
@StefanStojanovic I've kept 63589e5. Can you point me to the V8 CL that would make it obsolete? |
My third CL landed 5 days ago. That should be the last one needed. In case you need the other CLs, this is the second one that landed a month ago, and the first one that landed 2 months ago |
|
Thanks, I updated the PR to cherry-pick that last commit instead of the floating patch. |
|
Failure in shared lib build: Same on SmartOS: |
This was referenced Jun 15, 2023
Major V8 updates are usually API/ABI incompatible with previous versions. This commit adapts NODE_MODULE_VERSION for V8 11.5. Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md
dllexport introduces issues when compiling with MSVC. PR-URL: nodejs#47251 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Richard Lau <[email protected]>
PR-URL: nodejs#45579 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> PR-URL: nodejs#47251 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Richard Lau <[email protected]>
It introduces process hangs on some platforms because Node.js doesn't tear down V8 correctly. Disable it while we work on a solution. Refs: nodejs#47297 Refs: https://bugs.chromium.org/p/v8/issues/detail?id=13902 PR-URL: nodejs#47450 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
Original commit message:
[win][msvc] fix cross-compilation for arm64
Cross-compiling x64 to ARM64 on Windows fails with MSVC. The reason is
the ProbeMemory function which uses asm() code prohibited in this case.
This change adds conditionalizing on V8_TRAP_HANDLER_SUPPORTED thus
removing the problematic parts of the code in MSVC cross-compilation.
This extends https://chromium-review.googlesource.com/c/v8/v8/+/3964232
in a way, as it wraps ProbeMemory usage inside of the "#ifdef
V8_TRAP_HANDLER_VIA_SIMULATOR" blocks.
This follows https://chromium-review.googlesource.com/c/v8/v8/+/4403215
and https://chromium-review.googlesource.com/c/v8/v8/+/4489305 as a part
of an effort to completely fix cross-compilation with MSVC.
Change-Id: I59d9a995fbc8ee1cee2807429fd44d8043c178fb
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4574697
Reviewed-by: Andreas Haas <[email protected]>
Reviewed-by: Mark Seaborn <[email protected]>
Commit-Queue: Mark Seaborn <[email protected]>
Cr-Commit-Position: refs/heads/main@{#88147}
Refs: v8/v8@15e31d6
Accept a new `step` break message.
`--no-harmony-sharedarraybuffer` was removed from V8 but it's still possible to disable the feature with `--enable-sharedarraybuffer-per-context`.
|
I don't see what's special about /cc @nodejs/cpp-reviewers |
|
5258be6 can be dropped due to upstream bug has been fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #48029 with two additional commits.