-
Notifications
You must be signed in to change notification settings - Fork 29.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v11.x backport] tls: add code for ERR_TLS_INVALID_PROTOCOL_METHOD #26952
[v11.x backport] tls: add code for ERR_TLS_INVALID_PROTOCOL_METHOD #26952
Conversation
Add an error code property to invalid `secureProtocol` method exceptions. PR-URL: nodejs#24729 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]>
In nodejs#24729, the error was changed to be a TypeError, which is the standard type for this kind of error. However, it was Error in 11.x and earlier, so revert that single aspect, so the backport can be semver-minor.
@nodejs/crypto @nodejs/lts @nodejs/tsc PTAL, trivial backport, just cherry-picked the semver-major, then reverted the change of the error type so it is Error again, not TypeError. I'm not sure the original PR even should have been semver-major, it seems we're taking a looser approach to these fine details of error types nowadays, I guess we are finding that user's don't actually depend on them? Passing an invalid string as the |
Bundling this into #26951 (comment) |
Backport-of: #24729
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes