Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v10.1.0 proposal #20606

Merged
merged 173 commits into from
May 9, 2018
Merged

v10.1.0 proposal #20606

merged 173 commits into from
May 9, 2018

Conversation

MylesBorins
Copy link
Contributor

@MylesBorins MylesBorins commented May 8, 2018

2018-05-08, Version 10.1.0 (Current), @MylesBorins

Notable Changes

  • console:
    • make console.table() use colored inspect (TSUYUSATO Kitsune) #20510
  • fs:
    • move fs/promises to fs.promises (cjihrig) #20504
  • http:
    • added aborted property to request (Robert Nagy) #20094
  • n-api:
    • initialize a module via a special symbol (Gabriel Schulhof) #20161
  • src:
    • add public API to expose the main V8 Platform (Allen Yonghuang Wang) #20447

Commits

  • [7293c58d51] - assert: make skipping indicator blue (Ruben Bridgewater) #20315
  • [f5054d3412] - assert: minor error message improvements (Ruben Bridgewater) #20315
  • [55af327f0b] - benchmark: track exec time in next-tick-exec (Anatoli Papirovski) #20462
  • [289e4cef3f] - benchmark: fix next-tick-depth (Anatoli Papirovski) #20461
  • [b0e6f10530] - benchmark: add bench for zlib gzip + gunzip cycle (Anna Henningsen) #20034
  • [6ff8e80f88] - build: check for different deprecation signatures (Ruben Bridgewater) #20384
  • [348d391a71] - build: remove --xcode configure switch (Ben Noordhuis) #20328
  • [2ce4b7cb8c] - build: do not depend on cp in PATH (Anna Henningsen) #20296
  • [c5b3459003] - build: use -9 with kill in Makefile (Rich Trott) #20195
  • [b5931e1d45] - child_process: name anonymous functions (Denis Fäcke) #20399
  • [ec2037da12] - child_process: fix leak when passing http sockets (Santiago Gimeno) #20305
  • [3b5c6f1c39] - (SEMVER-MINOR) console: make console.table() use colored inspect (TSUYUSATO Kitsune) #20510
  • [29bc735d42] - console: fix console.table() display edge case (Rich Trott) #20323
  • [f604c04734] - crypto: allocate more memory for cipher.update() (Yihong Wang) #20370
  • [dfcf20f5fd] - crypto: use new OpenSSL constants in CipherBase (Tobias Nießen) #20339
  • [e17280e8c9] - crypto: make pbkdf2 use checkIsArrayBufferView (Daniel Bevenius) #20251
  • [61e93963ce] - crypto: add checkIsArrayBufferView (Daniel Bevenius) #20251
  • [e81bb9f8a3] - crypto: add getIntOption function to reduce dupl (Daniel Bevenius) #20247
  • [391d2f830a] - crypto: simplify diffiehellman getFormat function (Daniel Bevenius) #20246
  • [bf22f4187c] - deps: patch V8 to 6.6.346.27 (Myles Borins) #20480
  • [da8bc6ab50] - deps: cherry-pick 76cab5f from upstream V8 (Michaël Zasso) #20350
  • [ff911405d8] - doc: match console.count()/countReset() signatures (Lambdac0re) #20599
  • [9593b35985] - doc: clarify this in event listeners (daGo) #20537
  • [b172f6b266] - doc: move tunniclm to Emeritus (Rich Trott) #20533
  • [9211def5ca] - doc: add trace category for fs sync methods (Chin Huang) #20526
  • [bc4d4f07ba] - doc: update "Who to cc..." in COLLABORATOR_GUIDE (Vse Mozhet Byt) #20564
  • [f42d6fa4a3] - doc: excise "periodically" before "emit events" (Jesse W. Collins) #20581
  • [4662820fa4] - doc: edit text about revoking deprecations (Rich Trott) #20519
  • [3b78f0dd70] - doc: edit text for DEP0013 (Rich Trott) #20519
  • [762051a286] - doc: minor edit to DEP0065 (Rich Trott) #20519
  • [bb8aae22d7] - doc: fix minor typographical error in DEP0079 text (Rich Trott) #20519
  • [bc31b48ec2] - doc: edit text for DEP0082 (Rich Trott) #20519
  • [44f80caacb] - doc: fix text for DEP0085 (Rich Trott) #20519
  • [f31944a516] - doc: edit text for DEP0094 (Rich Trott) #20519
  • [16c60a95e2] - doc: edit text for DEP0012 (Rich Trott) #20519
  • [e81790c93b] - doc: edit text for DEP0101 (Rich Trott) #20519
  • [82b34f3308] - doc: edit text for DEP0104 (Rich Trott) #20519
  • [252ca72a75] - doc: add parameters for Http2Session:stream event (Ujjwal Sharma) #20547
  • [5de1771ed5] - doc: clearer doc-only deprecations (Ruben Bridgewater) #20381
  • [38323bcf72] - doc: update one more command in crypto.md (Shobhit Chittora) #20500
  • [972b94ebd2] - doc: add snake_case section for C-like structs (Daniel Bevenius) #20423
  • [e362e0670a] - doc: updates crypto doc with openssl list -cipher-algorithms (Shobhit Chittora) #20502
  • [e94deb8206] - doc: fix N-API property descriptor documentation (Gabriel Schulhof) #20433
  • [a5ba30bbac] - doc: fix manpage warning (Jérémy Lal) #20383
  • [d2dd473d79] - doc: document using domain in REPL (Ayush Gupta) #20382
  • [1bead0fa0d] - doc: fix mkdtemp() documentation (Rich Trott) #20512
  • [d7db306d3b] - doc: update examples for fs.access() (BeniCheni) #20460
  • [b2d6eb74d4] - doc: cleanup n-api.md doc (Michael Dawson) #20430
  • [e5537477d4] - doc: update Collaborator Guide reference (Rich Trott) #20473
  • [391c420c3e] - doc: synchronize argument names for appendFile() (Rich Trott) #20489
  • [8b17e7ae04] - doc: update cli flag in crypto.md (Shobhit Chittora) #20400
  • [74685f1b8f] - doc: add missing periods in documentation.md (Vse Mozhet Byt) #20469
  • [b0ed31cf9c] - doc: update writing-and-running-benchmarks.md (xsbchen) #20379
  • [658fbdc105] - doc: add http.ClientRequest maxHeadersCount (Daiki Arai) #20361
  • [7a769ebba8] - doc: add squash guideline to pull-requests doc (Rich Trott) #20413
  • [166df9e15c] - doc: remove squash guideline from onboarding doc (Rich Trott) #20413
  • [56c27c6a2b] - doc: add more missing backticks (Vse Mozhet Byt) #20438
  • [abf11550b2] - doc: add missing periods or colons (Vse Mozhet Byt) #20401
  • [261776d6b4] - doc: mitigate marked bug (Vse Mozhet Byt) #20411
  • [54e93315ed] - doc: specify types of listener parameter (Vse Mozhet Byt) #20405
  • [fcc5492df2] - doc: clarify FileHandle text (Rich Trott) #20450
  • [5a839b9911] - doc: remove unclear text from fs.write() (Rich Trott) #20450
  • [459c20c0b8] - doc: edit fs.createReadStream() highWaterMark (Rich Trott) #20450
  • [f36a5e3ba5] - doc: remove redundant table of contents for N-API (Ayush Gupta) #20395
  • [4bc87c185b] - doc: add parameters for settings events (Ujjwal Sharma) #20371
  • [d7557e111e] - doc: refine napi_get_property_names() doc (Gabriel Schulhof) #20427
  • [b61ae7fe09] - doc: remove "has been known" tentativeness (Rich Trott) #20412
  • [de9d1f15de] - doc: remove parenthetical in onboarding-extras (Rich Trott) #20393
  • [5542a98aa4] - doc: improve process event headers (Ruben Bridgewater) #20312
  • [90026c3f3e] - doc: improve assert docs (Ruben Bridgewater) #20313
  • [57e5a3e15f] - doc: remove redundant empty lines (Vse Mozhet Byt) #20398
  • [9cf3ae5bc3] - doc: add missing backticks in n-api.md (Vse Mozhet Byt) #20390
  • [be34388a07] - doc: unify and dedupe returned values in timers.md (Vse Mozhet Byt) #20310
  • [9c11a18f70] - doc: remove eu-strip from tarball (jvelezpo) #20304
  • [b47044ac0f] - doc: improve parameters for Http2Session:goaway event (Ujjwal Sharma)
  • [701f536ef4] - doc: remove superfluous URL require statement (Mark Tiedemann) #20364
  • [d9bc9217a7] - doc: fix typo in console.md (Daniel Hritzkiv) #20349
  • [cc09d7ec5b] - doc: remove console.table() as inspector-dependent (Rich Trott) #20346
  • [14188b1266] - doc: add Slack community to support options (Tracy) #18191
  • [3a3144cf04] - doc: remove os.uptime() Windows note (cjihrig) #20308
  • [c139d2ab8d] - doc: fix unhandled to uncaught (Ruben Bridgewater) #20293
  • [7f6172b64b] - doc: improve docs for Http2Session:frameError (Ujjwal Sharma) #20236
  • [c9b202f817] - doc: add emitter.off() to events.md (Ajido) #20291
  • [3bf736e569] - doc: update pull request template in guide (Zachary Vacura) #20277
  • [171cbb1c64] - doc: fix net.Socket link inconsistencies (Hackzzila) #20271
  • [26525ef5ab] - doc: fix typos in doc/changelogs/CHANGELOG_V10.md (Vse Mozhet Byt) #20265
  • [3bc5353110] - doc: fix spelling of API name in 10.0.0 changelog (Tobias Nießen) #20257
  • [e67c08b04f] - errors: remove dead code (Ruben Bridgewater) #20483
  • [b89d8178b4] - errors: minor (SystemError) refactoring (Ruben Bridgewater) #20337
  • [58a65d6689] - events: optimize condition for optimal scenario (Anatoli Papirovski) #20452
  • [f5ca39dde5] - fs: fchmod->fchown in promises/lchown (Сковорода Никита Андреевич) #20407
  • [0dec568456] - fs: remove broken code in promises/write (Сковорода Никита Андреевич) #20407
  • [3191f30d0a] - fs: move fs/promises to fs.promises (cjihrig) #20504
  • [e45e5b809d] - fs: point isFd to isUint32 (Daniel Bevenius) #20330
  • [f0b2b2605a] - http: refactor outgoing headers processing (Anatoli Papirovski) #20250
  • [1385ffcccf] - (SEMVER-MINOR) http: added aborted property to request (Robert Nagy) #20094
  • [a438d25789] - http2: rename http2_state class to Http2State (Daniel Bevenius) #20423
  • [42bbaa338d] - http2: reduce require calls in http2/core (Daniel Bevenius) #20422
  • [e397d19e58] - http2: remove unnecessary v8 qualified names (Daniel Bevenius) #20420
  • [b2bbc3619e] - http2: remove unused using declarations node_http2 (Daniel Bevenius) #20420
  • [7d9f1f3971] - http2: fix ping callback (Ruben Bridgewater) #20311
  • [46bd86235d] - http2: fix responses to long payload reqs (Anatoli Papirovski) #20084
  • [d55f90dc80] - https: defines maxHeadersCount in the constructor (Daiki Arai) #20359
  • [1490164230] - inspector: allow concurrent inspector sessions (Eugene Ostroukhov) #20137
  • [375994f940] - inspector: Use default uv_listen backlog size (Eugene Ostroukhov) #20254
  • [d0cbb4c530] - lib: expose FixedQueue internally and fix nextTick bug (Anatoli Papirovski) #20468
  • [b6de6a7e35] - lib: named anonymous functions (Carrie Coxwell) #20408
  • [9eacd66bcb] - lib: make sure console is writable (Kyle Farnung) #20185
  • [17dbf6c77f] - n-api: make test_error functions static (Gabriel Schulhof)
  • [ad793ab93c] - n-api: test and doc napi_throw() of a primitive (Gabriel Schulhof) #20428
  • [1908668826] - n-api: document the look of napi_external values (Gabriel Schulhof) #20426
  • [7ac491b8ac] - n-api: document that native strings are copied (Gabriel Schulhof) #20425
  • [705d9ecd13] - n-api: remove unused Test function (Daniel Bevenius) #20320
  • [8d24b6ed34] - n-api: update cli documentation (Gabriel Schulhof) #20301
  • [cd83df386b] - (SEMVER-MINOR) n-api: initialize a module via a special symbol (Gabriel Schulhof) #20161
  • [b5c1c146f5] - n-api,test: remove superfluous persistent (Gabriel Schulhof) #20299
  • [2de3343474] - n-api,test: make method static (Gabriel Schulhof) #20292
  • [b239591ed8] - n-api,test: make methods static (Gabriel Schulhof) #20243
  • [f2aca748a9] - repl: add spaces to load/save messages (cjihrig) #20536
  • [925939afe0] - src: more automatic memory management in node_crypto.cc (Anna Henningsen) #20238
  • [71f8f12dae] - (SEMVER-MINOR) src: add public API to expose the main V8 Platform (Allen Yonghuang Wang) #20447
  • [380dfe4234] - src: removed unnecessary prototypes from Environment::SetProtoMethod (Brandon Ruggles) #20321
  • [5dc293d3f3] - src: fix inconsistency in extern declaration (Yang Guo) #20436
  • [f5d42532a3] - src: refactor BaseObject internal field management (Anna Henningsen) #20455
  • [c21a52f415] - src: access ContextifyContext\* more directly in property cbs (Anna Henningsen) #20455
  • [c0f153528e] - src: remove kFlagNoShutdown flag (Anna Henningsen) #20388
  • [58be6efd29] - src: avoid std::make\_unique (Anna Henningsen) #20386
  • [31812edb2d] - src: remove unnecessary copy operations in tracing (Anna Henningsen) #20356
  • [e0d2bc5cce] - src: improve fatal exception (Ruben Bridgewater) #20294
  • [44fdd36b96] - src: remove SecureContext \_external getter (Anna Henningsen) #20237
  • [81de533836] - src: create per-isolate strings after platform setup (Ulan Degenbaev) #20175
  • [b5bc6bd94b] - src: fix Systemtap node_gc_stop probe (William Cohen) #20152
  • [6bf816fde2] - src: limit foreground tasks draining loop (Ulan Degenbaev) #19987
  • [bd2e521096] - src: rename return var in VerifySpkac functions (Daniel Bevenius) #20218
  • [a4dae6c226] - src: prefer false instead of bool zero (Daniel Bevenius) #20218
  • [931408e4b6] - Revert "stream: prevent 'end' to be emitted after 'error'" (Brian White) #20449
  • [05b7b8d506] - stream: fix error handling with async iteration (Julien Fontanet) #20329
  • [fd912a37a0] - stream: only check options once in Duplex ctor (Daniel Bevenius) #20353
  • [36be8bbcc6] - test: fix flaky http2-flow-control test (Anatoli Papirovski) #20556
  • [4b2e8868a2] - test: use common.canCreateSymLink() consistently (cjihrig) #20540
  • [daa0940696] - test: fix test-cli-node-options.js on mips (Ruben Bridgewater) #20377
  • [f6f69aafc7] - test: fix buffer writes on mips (Ruben Bridgewater) #20377
  • [73f2dabf7d] - test: fix common.canCreateSymLink() on non-Windows (Masashi Hirano) #20511
  • [21f057754b] - test: fix up N-API error test (Gabriel Schulhof) #20487
  • [17e4c8bd48] - test: rename misnamed test (Rich Trott) #20532
  • [27921e2f3c] - test: add fs/promises filehandle stat test (Masashi Hirano) #20492
  • [4dce39a919] - test: use fs.copyFileSync() (Richard Lau) #20340
  • [b24ee078f6] - test: remove unnecessary strictEqual() argument from remoteClose() (Daylor Yanes) #20343
  • [2b8b40f800] - test: fix a TODO and remove obsolete TODOs (Ruben Bridgewater) #20319
  • [645a97a44e] - test: verify arguments length in common.expectsError (Ruben Bridgewater) #20311
  • [b646566ab4] - test: removed assert.strictEqual message (kailash k yogeshwar) #20223
  • [61a56fe437] - test: added coverage for fs/promises API (Mithun Sasidharan) #20219
  • [769b6c8fd2] - test: fix flaky child-process-exec-kill-throws (Santiago Gimeno) #20213
  • [99e0b913c6] - test: add checkMethods function for Certificate (Daniel Bevenius) #20224
  • [d4b19cf43f] - test,n-api: re-write test_error in C (Gabriel Schulhof) #20244
  • [e552158dd2] - timers: named anonymous functions (Kyle Martin) #20397
  • [e1170db76d] - tls: remove sharedCreds in Server constructor (Daniel Bevenius) #20491
  • [cfb2f34ca6] - tls: cleanup onhandshakestart callback (Anatoli Papirovski) #20466
  • [9b30bc4f81] - tls: fix getEphemeralKeyInfo to support X25519 (Shigeki Ohtsu) #20273
  • [73cd2798df] - tls: specify options.name in validateKeyCert (Daniel Bevenius) #20284
  • [f17a71181e] - tools: add eslint check for skipIfEslintMissing (Richard Lau) #20372
  • [b6168bb084] - tools: add v10 to alternative version docs menu (Vse Mozhet Byt) #20586
  • [b215f92979] - tools: remove redundant code in doc/html.js (Vse Mozhet Byt) #20514
  • [3912551252] - tools: fix TypeError from test.py --time (Richard Lau) #20368
  • [b0c0352742] - tools: dedupe property access in doc/type-parser (Vse Mozhet Byt) #20387
  • [ccf1b24af2] - tools: remove redundant RegExp flag (Vse Mozhet Byt) #20309
  • [a12d13ad06] - tools: simplify HTML generation (Vse Mozhet Byt) #20307
  • [8ddbac2fd6] - tools: add log output to crashes (Ruben Bridgewater) #20295
  • [ab13f13a6c] - tools: show stdout/stderr for timed out tests (Rich Trott) #20260
  • [b5584c448a] - tools: modernize and optimize doc/addon-verify.js (Vse Mozhet Byt) #20188
  • [2a5496532f] - url: fix WHATWG host formatting error (Yichao 'Peak' Ji) #20493
  • [1b9c40cc71] - util: named anonymous functions (Carrie Coxwell) #20408
  • [e854c953fd] - util: improve spliceOne perf (Anatoli Papirovski) #20453
  • [3962c734ae] - util: fix isInsideNodeModules inside error (Anatoli Papirovski) #20266

Gabriel Schulhof and others added 30 commits May 4, 2018 11:47
Much like regular modules, N-API modules can also benefit from having
a special symbol which they can expose.

Fixes: #19845
PR-URL: #20161
Reviewed-By: Ben Noordhuis <[email protected]>
This commit updates node_crypto.cc VerifySpkac function to use false
instead of 0 for its return bool value i.

PR-URL: #20218
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
This commit renames the verification result variable, that is currently
named i, to verify_result.

PR-URL: #20218
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
The code currently assumes that `console` is already writable, but
that's only if it was previously defined as writable. If it hasn't
already been defined then the default value is false.

Refs: #17708

PR-URL: #20185
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Modernize:
* Replace `var` with `const` / `let`.
* Replace common functions with arrow functions.
* Use destructuring.
* Use `String.prototype.padStart()`, `String.prototype.endsWith()`.

Optimize:
* Reduce function calls.
* Reduce intermediate variables.
* Cache retrieved object properties.
* Move RegExp declaration out of a cycle.
* Simplify RegExps.
* Replace RegExp with string when string suffices.
* Remove conditions that cannot be false.
* Replace for..in with `Object.keys().forEach()`.

Also, eliminate needlessly complicated function chains:
* `ondone` callback only checks errors;
* if there is an error, it is called once and throws, then script exits;
* if there are no errors, it is noop;
* so there is no need to wrap it into `once()` function
* and there is no need to call it without errors;
* we can eliminate it and replace with `throw` where an error occurs;
* we can also replace `onprogress` callback with `console.log` in place;
* at last, we can eliminate `waiting` counter and `once()` utility.

The new script produces results identical to the old ones.

PR-URL: #20188
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Fixes: #20194

PR-URL: #20195
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
PR-URL: #20257
Refs: #19403
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
PR-URL: #20265
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
This commit adds a checkMethods function so that it can be reused to
avoid duplicating the same code for instance methods, and static
methods of the Certificate object.

PR-URL: #20224
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Foreground tasks that repost themselves can force the draining loop
to run indefinitely long without giving other tasks chance to run.

This limits the foreground task draining loop to run only the tasks
that were in the tasks queue at the beginning of the loop.

PR-URL: #19987
Fixes: #19937
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yang Guo <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
PR-URL: #20271
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #20277
Refs: #19125
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #20244
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
PR-URL: #20243
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
The process("node").mark("gc__stop") is actually
process("node").mark("gc__done"). Use the proper name so that a
developer can use SystemTap to determine the duration of garbage
collection.

PR-URL: #20152
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
PR-URL: #20291
Refs: #17156
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Improve documentation regarding the callback parameters for the
frameError event for instances of Http2Session, making it inline with
the currently accepted structure, like the rest of the documentation.

Refs: nodejs/help#877 (comment)

PR-URL: #20236
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
This commit aims to simplify the getFormat function in
diffiehellman.js.

PR-URL: #20246
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
This commit adds a getIntOption function to reduce the code duplicated
for getting the padding, and saltLength options.

PR-URL: #20247
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
This commit adds a checkIsArrayBufferView function to avoid some code
duplication in sig.js

PR-URL: #20251
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
This commit updates pbkdf2 to use checkIsArrayBufferView from
internal/crypto/util.

PR-URL: #20251
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Kill the child process with `SIGKILL` to make sure the child process
does not remain alive.

Fixes: #20139

PR-URL: #20213
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: James M Snell <[email protected]>
One non-static method remains

PR-URL: #20292
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Fixes: #20082
PR-URL: #20301
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Remove a superfluos persistent from test_constructor_name.c.

PR-URL: #20299
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #20254
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Ali Ijaz Sheikh <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
PR-URL: #20094
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #20219
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
PR-URL: #20223
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Allocation of strings may cause a garbage collection that uses
the platform to post tasks.

PR-URL: #20175
Fixes: #20171
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yang Guo <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Trott and others added 10 commits May 8, 2018 18:26
tunniclm indicated that it would be a good idea to move them to
Collaborator Emeritus for now. This commit makes that change in the
README.md file.

PR-URL: #20533
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
That code expects the last argument to be a callback.
When it's not a callback, it shifts arguments, defaulting
encoding to 'utf-8', which is clearly broken.

Old signature: (fd, string[, position[, encoding]], callback)
New signature: (fd, string[, position[, encoding]])

PR-URL: #20407
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jamie Davis <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
This was a clear error.

chown should do chown, not chmod.

PR-URL: #20407
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jamie Davis <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
this === eventEmitter or this === instance of EventEmitter,
but it's this is not EventEmitter.

PR-URL: #20537
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
PR-URL: #20586
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
This commit replaces two ad hoc symlink permission tests with
common.canCreateSymLink().

PR-URL: #20540
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Add a custom eslint rule to check for `common.skipIfEslintMissing()` to
allow tests to run from source tarballs that do not include eslint.

Fix up rule tests that were failing the new check.

Refs: #20336

PR-URL: #20372
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
PR-URL: #20599
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #20556
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Notable Changes:

* console:
  - make console.table() use colored inspect (TSUYUSATO Kitsune)
    #20510
* fs:
  - move fs/promises to fs.promises (cjihrig)
    #20504
* http:
  - added aborted property to request (Robert Nagy)
    #20094
* n-api:
  - initialize a module via a special symbol (Gabriel Schulhof)
    #20161
* src:
  - add public API to expose the main V8 Platform (Allen Yonghuang Wang)
    #20447

PR-URL: #20606
@MylesBorins
Copy link
Contributor Author

Failing test was due to a #20370 which should not have landed yet

One more ci: https://ci.nodejs.org/job/node-test-pull-request/14722/

@MylesBorins
Copy link
Contributor Author

CI is looking good! Moving forward with release

@MylesBorins MylesBorins merged commit 687867d into v10.x May 9, 2018
MylesBorins added a commit that referenced this pull request May 9, 2018
MylesBorins added a commit that referenced this pull request May 9, 2018
Notable Changes:

* console:
  - make console.table() use colored inspect (TSUYUSATO Kitsune)
    #20510
* fs:
  - move fs/promises to fs.promises (cjihrig)
    #20504
* http:
  - added aborted property to request (Robert Nagy)
    #20094
* n-api:
  - initialize a module via a special symbol (Gabriel Schulhof)
    #20161
* src:
  - add public API to expose the main V8 Platform (Allen Yonghuang Wang)
    #20447

PR-URL: #20606
@targos targos deleted the v10.1.0-proposal branch June 20, 2018 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.