Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend shared library interface #19005

Closed
wants to merge 66 commits into from
Closed

Extend shared library interface #19005

wants to merge 66 commits into from

Commits on Feb 7, 2018

  1. Squash commit of all our previous commits

    @msoechting
    msoechting committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    32932e4 View commit details
    Browse the repository at this point in the history

  2. Fix errors introduced by merge

    @EmberFlare
    EmberFlare committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    99b9de7 View commit details
    Browse the repository at this point in the history

  3. Further merge fixes

    @EmberFlare
    EmberFlare committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    7f6a8d5 View commit details
    Browse the repository at this point in the history

  4. Update our init- and deinitialize methods with new master code

    @luminosuslight
    luminosuslight committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    208db30 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2018

  1. replay central changes from refactor-start branch on new dev

    @justus-hildebrand
    justus-hildebrand committed Feb 12, 2018
    Configuration menu
    Copy the full SHA
    1ca52b3 View commit details
    Browse the repository at this point in the history

  2. Added code from initial PR (#62)

    Johannes Schneider committed Feb 12, 2018
    Configuration menu
    Copy the full SHA
    c77d2a1 View commit details
    Browse the repository at this point in the history

  3. replay changes from fix-repl branch on new dev

    @justus-hildebrand
    justus-hildebrand committed Feb 12, 2018
    Configuration menu
    Copy the full SHA
    e51dc56 View commit details
    Browse the repository at this point in the history

  4. fix linter error

    @justus-hildebrand
    justus-hildebrand committed Feb 12, 2018
    Configuration menu
    Copy the full SHA
    9bd425b View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2018

  1. fix small code smells 

    fixes issues pointed out in PR review
    @justus-hildebrand
    justus-hildebrand committed Feb 13, 2018
    Configuration menu
    Copy the full SHA
    bae6b4d View commit details
    Browse the repository at this point in the history

  2. fix linter

    @justus-hildebrand
    justus-hildebrand committed Feb 13, 2018
    Configuration menu
    Copy the full SHA
    e2e25de View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2018

  1. Merge pull request #67 from hpicgs/deinitialization 

    Deinitialization with dev as base
    Johannes Schneider authored Feb 15, 2018
    Configuration menu
    Copy the full SHA
    b2a8f79 View commit details
    Browse the repository at this point in the history

  2. Add if around eval script

    @luminosuslight
    luminosuslight committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    0abe5a4 View commit details
    Browse the repository at this point in the history

  3. Clean code

    @luminosuslight
    luminosuslight committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    d133ec8 View commit details
    Browse the repository at this point in the history

  4. Fix documentation

    @luminosuslight
    luminosuslight committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    be93498 View commit details
    Browse the repository at this point in the history

  5. Merge pull request #69 from hpicgs/new-fix-repl 

    Replay "allow optional REPL" on new dev
    @luminosuslight
    luminosuslight authored Feb 15, 2018
    Configuration menu
    Copy the full SHA
    aad189a View commit details
    Browse the repository at this point in the history

  6. Merge pull request #68 from hpicgs/new-refactor-start 

    Replay "refactor Start() methods to use lib functions" onto new dev
    @luminosuslight
    luminosuslight authored Feb 15, 2018
    Configuration menu
    Copy the full SHA
    1959f89 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2018

  1. Fix REPL spawning

    @cmfcmf
    cmfcmf committed Feb 19, 2018
    Configuration menu
    Copy the full SHA
    40b20d8 View commit details
    Browse the repository at this point in the history

  2. Add missing function declaration

    @cmfcmf
    cmfcmf committed Feb 19, 2018
    Configuration menu
    Copy the full SHA
    cdce802 View commit details
    Browse the repository at this point in the history

  3. Fix typo

    @cmfcmf
    cmfcmf committed Feb 19, 2018
    Configuration menu
    Copy the full SHA
    e7f40c1 View commit details
    Browse the repository at this point in the history

  4. Correctly deinitialize context

    @cmfcmf
    cmfcmf committed Feb 19, 2018
    Configuration menu
    Copy the full SHA
    c52a994 View commit details
    Browse the repository at this point in the history

  5. Fix style, remove debug output

    @cmfcmf
    cmfcmf committed Feb 19, 2018
    Configuration menu
    Copy the full SHA
    6d53a55 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2018

  1. Fix require not available in shared mode

    @luminosuslight
    luminosuslight committed Feb 21, 2018
    Configuration menu
    Copy the full SHA
    efc78d6 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #77 from hpicgs/deini-fix 

    Correctly deinitialize context
    @msoechting
    msoechting authored Feb 21, 2018
    Configuration menu
    Copy the full SHA
    ab7db6c View commit details
    Browse the repository at this point in the history

  3. Merge pull request #78 from hpicgs/fix-allow-repl 

    Fix require not available in shared mode
    @msoechting
    msoechting authored Feb 21, 2018
    Configuration menu
    Copy the full SHA
    883795c View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2018

  1. Merge branch 'dev' into repl-fix

    @cmfcmf
    cmfcmf authored Feb 25, 2018
    Configuration menu
    Copy the full SHA
    b7621f0 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into dev

    @cmfcmf
    cmfcmf committed Feb 25, 2018
    Configuration menu
    Copy the full SHA
    8fb4446 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2018

  1. Bring comment in bootstrap_node.js back

    @luminosuslight
    luminosuslight committed Feb 26, 2018
    Configuration menu
    Copy the full SHA
    a8dc3fa View commit details
    Browse the repository at this point in the history

  2. Re-add error handling for initialize

    @cmfcmf
    cmfcmf committed Feb 26, 2018
    Configuration menu
    Copy the full SHA
    35ff063 View commit details
    Browse the repository at this point in the history

  3. Improved usage documentation (#72) 

    * Start advanced doc

* Remove lib namespace from documentation

* Update code (thanks Johannes)

* Fix typos

* Fix a few typos

* Update usage doc

* Update comments in usage doc

* Update more comments in usage doc

* Updated with refactored code from node-embed

* Rename itemTitle to item
    @msoechting @cmfcmf
    msoechting authored and cmfcmf committed Feb 26, 2018
    Configuration menu
    Copy the full SHA
    984c3ea View commit details
    Browse the repository at this point in the history

  4. Remove deinitialize code

    @cmfcmf
    cmfcmf committed Feb 26, 2018
    Configuration menu
    Copy the full SHA
    1e9c2f7 View commit details
    Browse the repository at this point in the history

  5. Remove some comments, adjust TODOs (#79) 

    * Remove some comments, adjust TODO

* Fix line length

* Update node.cc

* changed names in comments

* changed naming in comments according to Node.js schema

* added missing 'TODO'
    @cmfcmf
    cmfcmf authored Feb 26, 2018
    Configuration menu
    Copy the full SHA
    2d2227d View commit details
    Browse the repository at this point in the history

  6. Merge branch 'dev' into error-handling

    @cmfcmf
    cmfcmf authored Feb 26, 2018
    Configuration menu
    Copy the full SHA
    6036ee2 View commit details
    Browse the repository at this point in the history

  7. Fix cs

    @cmfcmf
    cmfcmf committed Feb 26, 2018
    Configuration menu
    Copy the full SHA
    737c015 View commit details
    Browse the repository at this point in the history

  8. Fix indent

    @cmfcmf
    cmfcmf committed Feb 26, 2018
    Configuration menu
    Copy the full SHA
    873f871 View commit details
    Browse the repository at this point in the history

  9. Rename parameter to evaluate_stdin

    @cmfcmf
    cmfcmf committed Feb 26, 2018
    Configuration menu
    Copy the full SHA
    b60ad85 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'dev' into repl-fix

    @cmfcmf
    cmfcmf committed Feb 26, 2018
    Configuration menu
    Copy the full SHA
    8826721 View commit details
    Browse the repository at this point in the history

  11. Merge pull request #80 from hpicgs/error-handling 

    Re-add error handling for initialize
    @cmfcmf
    cmfcmf authored Feb 26, 2018
    Configuration menu
    Copy the full SHA
    e751664 View commit details
    Browse the repository at this point in the history

  12. Whoopsidoopsi

    @cmfcmf
    cmfcmf committed Feb 26, 2018
    Configuration menu
    Copy the full SHA
    2b67156 View commit details
    Browse the repository at this point in the history

  13. removed travis.yaml in preparation for PR

    Johannes Schneider committed Feb 26, 2018
    Configuration menu
    Copy the full SHA
    a5f4250 View commit details
    Browse the repository at this point in the history

  14. Merge branch 'dev' into repl-fix

    @cmfcmf
    cmfcmf committed Feb 26, 2018
    Configuration menu
    Copy the full SHA
    695a8db View commit details
    Browse the repository at this point in the history

  15. fixed linter errors

    Johannes Schneider committed Feb 26, 2018
    Configuration menu
    Copy the full SHA
    ad630a5 View commit details
    Browse the repository at this point in the history

  16. Merge branch 'dev' into repl-fix

    @cmfcmf
    cmfcmf authored Feb 26, 2018
    Configuration menu
    Copy the full SHA
    3d0865e View commit details
    Browse the repository at this point in the history

  17. Fix doc comment

    @cmfcmf
    cmfcmf committed Feb 26, 2018
    Configuration menu
    Copy the full SHA
    3aad7e8 View commit details
    Browse the repository at this point in the history

  18. Merge branch 'repl-fix' of github.com:hpicgs/node into repl-fix

    @cmfcmf
    cmfcmf committed Feb 26, 2018
    Configuration menu
    Copy the full SHA
    9811298 View commit details
    Browse the repository at this point in the history

  19. Merge pull request #75 from hpicgs/repl-fix 

    Fix REPL spawning
    Johannes Schneider authored Feb 26, 2018
    Configuration menu
    Copy the full SHA
    385de54 View commit details
    Browse the repository at this point in the history

  20. removed trailling whitespaces

    Johannes Schneider committed Feb 26, 2018
    Configuration menu
    Copy the full SHA
    f23feec View commit details
    Browse the repository at this point in the history

  21. Fix line length

    @luminosuslight
    luminosuslight committed Feb 26, 2018
    Configuration menu
    Copy the full SHA
    9213545 View commit details
    Browse the repository at this point in the history

  22. Merge branch 'dev' into node-lib-interface

    @luminosuslight
    luminosuslight committed Feb 26, 2018
    Configuration menu
    Copy the full SHA
    e916467 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2018

  1. POC of environments in all library methods

    @cmfcmf
    cmfcmf committed Mar 13, 2018
    Configuration menu
    Copy the full SHA
    0f63853 View commit details
    Browse the repository at this point in the history

  2. Add missing environment to Call()

    @cmfcmf
    cmfcmf committed Mar 13, 2018
    Configuration menu
    Copy the full SHA
    f9060d3 View commit details
    Browse the repository at this point in the history

  3. Remove Isolate::CreateParams, Isollate::Scope and Context::Scope as g… 

    …lobals
    @cmfcmf
    cmfcmf committed Mar 13, 2018
    Configuration menu
    Copy the full SHA
    81e9d6a View commit details
    Browse the repository at this point in the history

  4. Remove _isolate variable (unsure about this)

    @cmfcmf
    cmfcmf committed Mar 13, 2018
    Configuration menu
    Copy the full SHA
    c70d931 View commit details
    Browse the repository at this point in the history

  5. Fix cs

    @cmfcmf
    cmfcmf committed Mar 13, 2018
    Configuration menu
    Copy the full SHA
    3aeb883 View commit details
    Browse the repository at this point in the history

  6. Remove initializer_list methods

    @cmfcmf
    cmfcmf committed Mar 13, 2018
    Configuration menu
    Copy the full SHA
    c357218 View commit details
    Browse the repository at this point in the history

  7. Merge pull request #84 from hpicgs/remove-initializer-lists 

    Remove initializer_list methods
    @luminosuslight
    luminosuslight authored Mar 13, 2018
    Configuration menu
    Copy the full SHA
    a686c96 View commit details
    Browse the repository at this point in the history

  8. Fix ignored return value of uv_setup_args

    @luminosuslight
    luminosuslight committed Mar 13, 2018
    Configuration menu
    Copy the full SHA
    646388a View commit details
    Browse the repository at this point in the history

  9. Merge pull request #86 from hpicgs/fix-argv-process-title 

    Fix ignored return value of uv_setup_args
    @cmfcmf
    cmfcmf authored Mar 13, 2018
    Configuration menu
    Copy the full SHA
    319f9ef View commit details
    Browse the repository at this point in the history

  10. Remove outdated TODO

    @cmfcmf
    cmfcmf committed Mar 13, 2018
    Configuration menu
    Copy the full SHA
    5e2fe3b View commit details
    Browse the repository at this point in the history

  11. Merge remote-tracking branch 'origin/dev' into remove-globals

    @cmfcmf
    cmfcmf committed Mar 13, 2018
    Configuration menu
    Copy the full SHA
    05e8b99 View commit details
    Browse the repository at this point in the history

  12. Merge pull request #83 from hpicgs/remove-globals 

    Remove some globals
    @cmfcmf
    cmfcmf authored Mar 13, 2018
    Configuration menu
    Copy the full SHA
    c2febfb View commit details
    Browse the repository at this point in the history

  13. Add documentation and remove initializer_list call methods

    @luminosuslight
    luminosuslight committed Mar 13, 2018
    Configuration menu
    Copy the full SHA
    568191e View commit details
    Browse the repository at this point in the history

  14. Merge remote-tracking branch 'origin/dev' into add-environment

    @cmfcmf
    cmfcmf committed Mar 13, 2018
    Configuration menu
    Copy the full SHA
    d493e9a View commit details
    Browse the repository at this point in the history

  15. Remove implementation of init_list methods, too, and fix namespace

    @luminosuslight
    luminosuslight committed Mar 13, 2018
    Configuration menu
    Copy the full SHA
    1fbcc75 View commit details
    Browse the repository at this point in the history

  16. Merge branch 'add-environment' of github.com:hpicgs/node into add-env… 

    …ironment
    @cmfcmf
    cmfcmf committed Mar 13, 2018
    Configuration menu
    Copy the full SHA
    f1196ca View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2018

  1. Merge pull request #82 from hpicgs/add-environment 

    Add environment to all library methods
    @cmfcmf
    cmfcmf authored Mar 17, 2018
    Configuration menu
    Copy the full SHA
    9d6e944 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #87 from hpicgs/dev 

    Merge dev into PR branch
    @cmfcmf
    cmfcmf authored Mar 17, 2018
    Configuration menu
    Copy the full SHA
    cfae579 View commit details
    Browse the repository at this point in the history