console: treat non-strings as separate argument in console.assert()

fixes #49680 PR-URL: #49722 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
nodejs · Nov 1, 2023 · 60e8364 · 60e8364
1 parent 3095086
commit 60e8364
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 1 deletion.
diff --git a/lib/internal/console/constructor.js b/lib/internal/console/constructor.js
@@ -430,9 +430,14 @@ const consoleMethods = {
     this.error(err.stack);
   },
 
+  // Defined by: https://console.spec.whatwg.org/#assert
   assert(expression, ...args) {
     if (!expression) {
-      args[0] = `Assertion failed${args.length === 0 ? '' : `: ${args[0]}`}`;
+      if (args.length && typeof args[0] === 'string') {
+        args[0] = `Assertion failed: ${args[0]}`;
+      } else {
+        ArrayPrototypeUnshift(args, 'Assertion failed');
+      }
       // The arguments will be formatted in warn() again
       ReflectApply(this.warn, this, args);
     }

diff --git a/test/message/console_assert.js b/test/message/console_assert.js
@@ -0,0 +1,5 @@
+'use strict';
+
+require('../common');
+
+console.assert(false, Symbol('hello'));
diff --git a/test/message/console_assert.out b/test/message/console_assert.out
@@ -0,0 +1 @@
+Assertion failed* Symbol(hello)