build: build v8 with -fvisibility=hidden

This enables -fvisibility=hidden on platforms other than macOS, wherever it's supported.
nodejs · Dec 17, 2024 · 3752a7e · 3752a7e
1 parent 3b1bdd4
commit 3752a7e
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/tools/v8_gypfiles/v8.gyp b/tools/v8_gypfiles/v8.gyp
@@ -42,8 +42,7 @@
       }
     },
     # Hide symbols that are not explicitly exported with V8_EXPORT.
-    # TODO(joyeecheung): enable it on other platforms. Currently gcc times out
-    # or run out of memory with -fvisibility=hidden on some machines in the CI.
+    'cflags': ['-fvisibility=hidden'],
     'xcode_settings': {
       'GCC_SYMBOLS_PRIVATE_EXTERN': 'YES',  # -fvisibility=hidden
     },