benchmark: add access async version to bench

PR-URL: #54747 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Rich Trott <[email protected]>
nodejs · Sep 12, 2024 · 237d7df · 237d7df
1 parent 4c1b98b
commit 237d7df
Showing 1 changed file with 26 additions and 6 deletions.
diff --git a/benchmark/fs/bench-accessSync.js b/benchmark/fs/bench-accessSync.js
@@ -10,6 +10,7 @@ fs.writeFileSync(tmpfile, 'this-is-for-a-benchmark', 'utf8');
 
 const bench = common.createBenchmark(main, {
   type: ['existing', 'non-existing', 'non-flat-existing'],
+  method: ['access', 'accessSync'],
   n: [1e5],
 });
 
@@ -23,7 +24,17 @@ function runBench(n, path) {
   }
 }
 
-function main({ n, type }) {
+function runAsyncBench(n, path) {
+  (function r(cntr, path) {
+    if (cntr-- <= 0)
+      return bench.end(n);
+    fs.access(path, () => {
+      r(cntr, path);
+    });
+  })(n, path);
+}
+
+function main({ n, type, method }) {
   let path;
 
   switch (type) {
@@ -39,10 +50,19 @@ function main({ n, type }) {
     default:
       new Error('Invalid type');
   }
-  // warmup
-  runBench(n, path);
 
-  bench.start();
-  runBench(n, path);
-  bench.end(n);
+  if (method === 'access') {
+    // Warmup the filesystem - it doesn't need to use the async method
+    runBench(n, path);
+
+    bench.start();
+    runAsyncBench(n, path);
+  } else {
+    // warmup
+    runBench(n, path);
+
+    bench.start();
+    runBench(n, path);
+    bench.end(n);
+  }
 }