Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gyp): update gyp to v0.15.0 #2825

Closed
wants to merge 5 commits into from
Closed

feat(gyp): update gyp to v0.15.0 #2825

wants to merge 5 commits into from

Conversation

rzhao271
Copy link
Contributor

@rzhao271 rzhao271 commented Apr 6, 2023

Checklist
  • npm install && npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

Update gyp to v0.15.0. Brings in SpectreMitigation flag support for MSVS along with some bug fixes and doc improvements.

@rzhao271 rzhao271 force-pushed the rzhao271/upgrade-gyp branch from 128cb3f to 0e1e3cc Compare April 6, 2023 19:49
@rzhao271
Copy link
Contributor Author

rzhao271 commented Apr 6, 2023

Looks like there's more linting errors.
I'm wondering whether the errors should be fixed on the gyp-next side first?

@cclauss
Copy link
Contributor

cclauss commented Apr 6, 2023

;-) nodejs/gyp-next#193

@rzhao271 rzhao271 mentioned this pull request Apr 10, 2023
Merged
@rzhao271 rzhao271 requested a review from cclauss May 1, 2023 17:39
@rzhao271
Copy link
Contributor Author

rzhao271 commented May 1, 2023 •
edited
Loading

CI tests fail, but I wonder whether it's from 02480f6? That commit's CI status looks similar to this PR's.

Edit: I'll try reverting the latest commit and seeing whether that helps.
Edit 2: The tests still fail, even though the latest commit is equivalent to the commit two commits before: https://github.com/nodejs/node-gyp/compare/ab81955..6cf18a9.

Edit June 30: Waiting on some gyp-next changes first.

@rzhao271 rzhao271 mentioned this pull request Jun 19, 2023
Merged
@cclauss
Copy link
Contributor

cclauss commented Sep 28, 2023

Please rebase this pull request.

@rzhao271 rzhao271 force-pushed the rzhao271/upgrade-gyp branch from 6cf18a9 to 74048cb Compare October 2, 2023 17:02
@joaomoreno
Copy link

@cclauss What can we do to get this rolling?

cclauss
cclauss reviewed Oct 23, 2023
View reviewed changes
gyp/.github/workflows/Python_tests.yml
matrix:
os: [macos-latest, ubuntu-latest] # , windows-latest]
python-version: ["3.7", "3.8", "3.9", "3.10", "3.11-dev"]
python-version: ["3.7", "3.8", "3.9", "3.10", "3.11", "3.12-dev"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
python-version: ["3.7", "3.8", "3.9", "3.10", "3.11", "3.12-dev"]
python-version: ["3.7", "3.8", "3.9", "3.10", "3.11", "3.12"]

cclauss
cclauss reviewed Oct 23, 2023
View reviewed changes
gyp/README.md
* `pipx install gyp-next`
```
Installing to a new venv 'gyp-next'
installed package gyp-next 0.13.0, installed using Python 3.10.6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
installed package gyp-next 0.13.0, installed using Python 3.10.6
installed package gyp-next 0.13.0, installed using Python 3.12.0

cclauss
cclauss reviewed Oct 23, 2023
View reviewed changes
gyp/pyproject.toml
"Programming Language :: Python :: 3.7",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",

cclauss
cclauss reviewed Oct 23, 2023
View reviewed changes
gyp/pyproject.toml
]

[project.optional-dependencies]
dev = ["flake8", "pytest"]
dev = ["flake8", "ruff", "pytest"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
dev = ["flake8", "ruff", "pytest"]
dev = ["ruff", "pytest"]

cclauss
cclauss reviewed Oct 23, 2023
View reviewed changes
gyp/pyproject.toml
"Q",
"W",
]
target-version = "py37"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
target-version = "py37"
target-version = "py38"

@cclauss
Copy link
Contributor

cclauss commented Oct 23, 2023 •
edited
Loading

I think we will want to get Python 3.12 support in this release.

@DeeDeeG DeeDeeG mentioned this pull request Oct 27, 2023
Merged
5 tasks
@rzhao271
Copy link
Contributor Author

Closing in favour of #2923

@rzhao271 rzhao271 closed this Oct 27, 2023
@rzhao271 rzhao271 deleted the rzhao271/upgrade-gyp branch October 27, 2023 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rzhao271 @cclauss @joaomoreno