Skip to content

Commit

Permalink
fix(git-node): ignore all non-gha nodes when checking for GitHub CI
Browse files Browse the repository at this point in the history
  • Loading branch information
aduh95 committed Sep 24, 2024
1 parent 9224469 commit ee1fdbf
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions lib/pr_checker.js
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ const GITHUB_SUCCESS_CONCLUSIONS = ['SUCCESS', 'NEUTRAL', 'SKIPPED'];
const FAST_TRACK_RE = /^Fast-track has been requested by @(.+?)\. Please 👍 to approve\.$/;
const FAST_TRACK_MIN_APPROVALS = 2;
const GIT_CONFIG_GUIDE_URL = 'https://github.com/nodejs/node/blob/99b1ada/doc/guides/contributing/pull-requests.md#step-1-fork';
const IGNORED_CHECK_SLUGS = ['dependabot', 'codecov'];

// eslint-disable-next-line no-extend-native
Array.prototype.findLastIndex ??= function findLastIndex(fn) {
Expand Down Expand Up @@ -374,9 +373,10 @@ export default class PRChecker {

// GitHub new Check API
for (const { status, conclusion, app } of checkSuites.nodes) {
if (app && IGNORED_CHECK_SLUGS.includes(app.slug)) {
if (app.slug !== 'github-actions') {
// Ignore Dependabot and Codecov check suites.
// They are expected to show up sometimes and never complete.
// They are expected to show up on PRs whose head branch is not on a
// fork and never complete.
continue;
}

Expand Down

0 comments on commit ee1fdbf

Please sign in to comment.