-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
the original C code do not compile with the current node binary. #533
base: main
Are you sure you want to change the base?
Conversation
@@ -186,7 +186,7 @@ static napi_value StartThread(napi_env env, napi_callback_info info) { | |||
} | |||
|
|||
// Free the per-addon-instance data. | |||
static void addon_getting_unloaded(napi_env env, void* data, void* hint) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
napi_env
should be the preferred type. Would you mind elaborating on the errors to be fixed?
Running on a ARM Mac: node --version
v20.16.0 cmake --version
cmake version 3.30.2 npm run test error from test script: Error in
|
I would like to add some github action to test all examples.
but I need the codebase to works first.