Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test): update pnpm tests to use current version of the package manger #621

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

joemckenney
Copy link

Follow suggestions for fix in #618

@MikeMcC399
Copy link
Contributor

@joemckenney

  • I was actually waiting for some feedback from the maintainers on issue Outdated pnpm 4.x - 6.x versions tested #618 before taking any steps to submit a PR myself. I guess I should have written that in the issue!
  • In the meantime I played around with the tests a little, and found that nock.db needs to be deleted and recreated. This PR fails in GitHub Actions for that reason.
  • This PR isn't testing pnpm with hashes. That is probably something that the maintainers would want to test, however I can't speak for them. Probably SHA1 should be tested. I don't know about continuing to test SHA224 though, since latest Corepack versions no longer create SHA224, although they still accept SHA224. Probably SHA512 should be tested in addition.

@joemckenney
Copy link
Author

  • In the meantime I played around with the tests a little, and found that nock.db needs to be deleted and recreated. This PR fails in GitHub Actions for that reason.
  • This PR isn't testing pnpm with hashes. That is probably something that the maintainers would want to test, however I can't speak for them. Probably SHA1 should be tested. I don't know about continuing to test SHA224 though, since latest Corepack versions no longer create SHA224, although they still accept SHA224. Probably SHA512 should be tested in addition.

Happy to take on both of these. Note that I don't see the failing GHA workflows on my end, presumably because I don't have permissions and/or i'm not a member?

@MikeMcC399
Copy link
Contributor

MikeMcC399 commented Feb 1, 2025

@joemckenney

  • Thanks for your willingness to work together!

  • The suggestion to update these versions was however rejected in Outdated pnpm 4.x - 6.x versions tested #618. Without sponsorship from a maintainer I would not expect this PR to be approved. So unless there is a change in direction from the maintainers I suggest not to invest more effort into this PR.

  • You don't see your workflow failing because your PR checks haven't been approved to run. I copied your branch joemckenney:joe/corepack/issues/618 to my fork and ran it there manually. You can see the failing log under https://github.com/MikeMcC399/corepack/actions/runs/13086183011

@aduh95
Copy link
Contributor

aduh95 commented Feb 1, 2025

A PR that increases the coverage the coverage (i.e. add new versions to test with) would probably be accepted. However, this one decreases the coverage (IMO it's actually good that we test Corepack still works for older releases), so I don't think that would be an improvement as is.

I share the sentiment that it is not worth investing your time – those versions are not special, if Corepack breaks with those one, it would also break with the one being tested. Since we test latest versions when they come out already, if seems to me this PR would only increase the maintenance burden (we'd have to send PRs everytime another release branch of pnpm is EOL / semver is cutoff) while improving Corepack reliability only marginally at best. If you were to send a PR that adds a workflow that somehow updates our tests, now we'd be talking, but it's up to you to decide whether it is worth investing the time to build such workflow for ultimately fixing a (IMO) non-issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants