-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove macOS for most projects #971
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a temporary change, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fine as a temp change
Yes, the idea is to restore them one by one over the time |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #971 +/- ##
=======================================
Coverage 96.44% 96.44%
=======================================
Files 28 28
Lines 2139 2139
=======================================
Hits 2063 2063
Misses 76 76 ☔ View full report in Codecov by Sentry. |
CI is green now 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Did the removal of |
macOS hasn't run on any of the last 4 or 5 CITGM runs in Jenkins. Is that something intentional that someone did or is that a strange anomaly to be looked at? |
(It last ran as part of https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3252/ but we're up to https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3257/ now and they all completed without a macOS job.) |
Ah that's probably nodejs/build#3452 -- we no longer run on macOS 10.15 for Node.js 21 (i.e. |
Yes, I think we can use one slot for it in Orka, based on this comment we can use |
@UlisesGascon I was referring to extra disk space usage (for the citgm-smoker workspace), not additional VMs. |
Based on #997, maybe it's time to land this? @UlisesGascon If you want to rebase this, please do! (Otherwise, I'll do it at some point and force-push it to your branch. Either way!) |
Refs: #959 (comment)
Checklist
npm test
passeshere