lookup: declare bankruptcy on flaky modules

Remove all modules that failed the latest 20.x release run. We need to be able to trust that a failed CITGM run is something that needs to be investigated.
nodejs · Sep 24, 2023 · f18997b · f18997b
1 parent 5ed8640
commit f18997b
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 111 deletions.
diff --git a/lib/lookup.json b/lib/lookup.json
@@ -55,10 +55,6 @@
     "prefix": "v",
     "skip": ["win32", "aix"]
   },
-  "bluebird": {
-    "prefix": "v",
-    "maintainers": "petkaantonov"
-  },
   "body-parser": {
     "flaky": "aix",
     "maintainers": "dougwilson"
@@ -90,7 +86,7 @@
     "maintainers": "mcollina",
     "flaky": ["rhel"],
     "prefix": "v",
-    "skip": ["aix", "win32"]
+    "skip": ["aix", "darwin", "win32"]
   },
   "coffeescript": {
     "maintainers": ["jashkenas", "GeoffreyBooth"],
@@ -105,20 +101,11 @@
     "maintainers": "ctalkington",
     "skip": "win32"
   },
-  "csv-parser": {
-    "prefix": "v",
-    "flaky": "win32",
-    "maintainers": "mafintosh"
-  },
   "debug": {
     "maintainers": ["qix", "tootallnate"],
     "skip": [true, "aix", "ppc", "s390", "win32"],
     "scripts": ["test:node", "lint"]
   },
-  "dicer": {
-    "prefix": "v",
-    "maintainers": "mscdex"
-  },
   "duplexer2": {
     "prefix": "v",
     "maintainers": ["shinn", "deoxxa"]
@@ -127,14 +114,6 @@
     "prefix": "v",
     "maintainers": "mafintosh"
   },
-  "ember-cli": {
-    "envVar": { "YARN_IGNORE_ENGINES": "true" },
-    "prefix": "v",
-    "flaky": ["win32", "rhel", "sles"],
-    "head": true,
-    "expectFail": "fips",
-    "maintainers": ["stefanpenner", "rwjblue", "Turbo87", "kellyselden"]
-  },
   "end-of-stream": {
     "prefix": "v",
     "maintainers": "mafintosh",
@@ -153,19 +132,10 @@
     "expectFail": "fips",
     "skip": ["win32"]
   },
-  "express": {
-    "flaky": "ppc",
-    "maintainers": "dougwilson",
-    "skip": "win32"
-  },
   "express-session": {
     "prefix": "v",
     "maintainers": "dougwilson"
   },
-  "fastify": {
-    "maintainers": ["mcollina", "delvedor"],
-    "prefix": "v"
-  },
   "flush-write-stream": {
     "prefix": "v",
     "maintainers": "mafintosh",
@@ -214,10 +184,6 @@
     "maintainers": "contra",
     "skip": "win32"
   },
-  "https-proxy-agent": {
-    "maintainers": "TooTallNate",
-    "scripts": ["build", "test"]
-  },
   "iconv": {
     "prefix": "v",
     "flaky": "aix",
@@ -235,6 +201,7 @@
   },
   "is-core-module": {
     "prefix": "v",
+    "skip": "win32",
     "maintainers": "ljharb",
     "scripts": ["tests-only"]
   },
@@ -277,13 +244,6 @@
     "maintainers": ["ralphtheninja", "vweevers"],
     "skip": "win32"
   },
-  "leveldown": {
-    "prefix": "v",
-    "useGitClone": true,
-    "flaky": ["ppc", "s390"],
-    "tags": "native",
-    "maintainers": ["ralphtheninja", "vweevers"]
-  },
   "libxmljs": {
     "prefix": "v",
     "flaky": ["aix", "sles", "rhel", "darwin"],
@@ -308,13 +268,10 @@
     "tags": "native",
     "maintainers": "wadey"
   },
-  "mime": {
-    "prefix": "v",
-    "maintainers": "broofa"
-  },
   "minimist": {
     "npm": true,
-    "maintainers": "substack"
+    "skip": "win32",
+    "maintainers": "ljharb"
   },
   "mkdirp": {
     "head": true,
@@ -332,18 +289,6 @@
     "maintainers": "ichernev",
     "skip": [true, "ppc", "s390"]
   },
-  "multer": {
-    "prefix": "v",
-    "skip": "win32",
-    "maintainers": "linusu"
-  },
-  "nan": {
-    "maintainers": ["nodejs/addon-api"],
-    "prefix": "v",
-    "scripts": ["rebuild-tests", "test"],
-    "tags": "native",
-    "head": true
-  },
   "node-gyp": {
     "envVar": { "FAST_TEST": "true" },
     "prefix": "v",
@@ -358,11 +303,6 @@
     "comment": "Flaky because of test timeouts",
     "skip": true
   },
-  "npm": {
-    "maintainers": ["nodejs/npm"],
-    "prefix": "v",
-    "skip": ["aix", "s390"]
-  },
   "path-to-regexp": {
     "prefix": "v",
     "maintainers": "blakeembrey",
@@ -386,11 +326,6 @@
     "comment": "Error message changes in V8 9.3",
     "repo": "https://github.com/pugjs/pug"
   },
-  "pump": {
-    "prefix": "v",
-    "maintainers": "mafintosh",
-    "skip": "win32"
-  },
   "pumpify": {
     "prefix": "v",
     "maintainers": "mafintosh",
@@ -426,17 +361,8 @@
   },
   "rewire": {
     "prefix": "v",
-    "maintainers": "jhnns"
-  },
-  "rimraf": {
-    "prefix": "v",
-    "flaky": "win32",
-    "maintainers": "isaacs"
-  },
-  "router": {
-    "prefix": "v",
-    "maintainers": "dougwilson",
-    "skip": "win32"
+    "maintainers": "jhnns",
+    "scripts": ["test -- --timeout 30000"]
   },
   "sax": {
     "skip": "win32",
@@ -454,10 +380,8 @@
   },
   "serialport": {
     "prefix": "serialport@",
-    "flaky": ["ppc", "rhel"],
     "tags": "native",
-    "maintainers": "reconbot",
-    "skip": ["win32"]
+    "maintainers": "reconbot"
   },
   "socket.io": {
     "maintainers": "rauchg",
@@ -497,7 +421,9 @@
   "tape": {
     "head": true,
     "prefix": "v",
-    "maintainers": "substack"
+    "skip": "win32",
+    "scripts": ["tests-only"],
+    "maintainers": "ljharb"
   },
   "thread-sleep": {
     "install": ["install", "--build-from-source"],
@@ -517,30 +443,13 @@
     "stripAnsi": true,
     "maintainers": "mcollina"
   },
-  "torrent-stream": {
-    "prefix": "v",
-    "maintainers": "mafintosh"
-  },
-  "tough-cookie": {
-    "maintainers": ["awaterma", "colincasey", "ruoho", "wjharney"]
-  },
   "uglify-js": {
     "prefix": "v",
     "flaky": ["ppc", "darwin"],
     "maintainers": "mishoo",
     "skip": ["12", true],
     "comment": "Tests timeout"
   },
-  "underscore": {
-    "flaky": ["aix", "s390"],
-    "skip": "win32",
-    "maintainers": "jashkenas",
-    "ignoreGitHead": true
-  },
-  "undici": {
-    "prefix": "v",
-    "maintainers": ["mcollina", "ronag"]
-  },
   "uuid": {
     "prefix": "v",
     "maintainers": ["ctavan", "broofa"],
@@ -568,13 +477,10 @@
     "maintainers": "tootallnate",
     "tags": "native"
   },
-  "winston": {
-    "flaky": ["win32", "ppc", "s390", "darwin"],
-    "maintainers": "indexzero"
-  },
   "ws": {
     "expectFail": "fips",
-    "maintainers": ["einaros", "3rd-Eden", "lpinca"]
+    "maintainers": ["einaros", "3rd-Eden", "lpinca"],
+    "scripts": ["test -- --timeout 30000"]
   },
   "yargs": {
     "comment": "Install from source is currently broken due to TS error",

diff --git a/lib/package-manager/test.js b/lib/package-manager/test.js
@@ -76,7 +76,7 @@ export async function test(packageManager, context) {
     scripts = context.module.scripts.map((script) => [
       packageManagerBin,
       'run',
-      script
+      ...script.split(' ')
     ]);
   } else {
     scripts = [[packageManagerBin, 'test']];

diff --git a/test/test-lookup.js b/test/test-lookup.js
@@ -65,10 +65,7 @@ test('lookup[getLookupTable]:', (t) => {
   });
   t.ok(table, 'table should exist');
   t.ok(table.lodash, 'lodash should be in the table');
-  t.ok(
-    table.underscore.maintainers,
-    'underscore should contain a maintainers parameter'
-  );
+  t.ok(table.weak.maintainers, 'weak should contain a maintainers parameter');
   t.end();
 });