-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ansible: fix promotion to R2 dist-prod for releases #3840
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
05cc876
to
cba1c39
Compare
Updating to use both |
This appears to have promoted everything for |
Due to R2 limitations, `aws s3 cp` and `aws s3 sync` only succeed in copying different sets of files across. Fortunately the sets are disjoint, so running both commands (ignoring errors) will copy all the files across. Update `resha_release.sh` to redirect to a log file the output from the `upload_to_cloudflare.sh` to prevent extra output interfering with the `release.sh` script.
upload_to_cloudflare.sh
changes
Updated with changes to get 22.11.0 successfully promoted to R2's dist-prod. Logs on the server are stored in |
aws s3 cp $staging_bucket/$relativedir/$tmpversion/ $dist_bucket/$relativedir/$tmpversion/ --endpoint-url=$cloudflare_endpoint --profile $cloudflare_profile --recursive --no-follow-symlinks | ||
# Due to R2 limitations, `aws s3 cp` and `aws s3 sync` only succeed in copying | ||
# different sets of files across. Fortunately the sets are disjoint, so running | ||
# both commands (ignoring errors) will copy all the files across. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of scope of this PR, but I wonder if it would be worth switching to rclone for moving files around like this? I've found it to be reliable across different S3 providers (rclone has various workarounds for different S3 providers.)
Due to R2 limitations,
aws s3 cp
andaws s3 sync
only succeed incopying different sets of files across. Fortunately the sets are
disjoint, so running both commands (ignoring errors) will copy all the
files across.
Update
resha_release.sh
to redirect to a log file the output from theupload_to_cloudflare.sh
to prevent extra output interfering with therelease.sh
script.Fixes: #3838
Refs: #3838 (comment)