Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: introduce #59

Merged
merged 4 commits into from
Aug 8, 2024
Merged

test: introduce #59

merged 4 commits into from
Aug 8, 2024

Conversation

AugustinMauroy
Copy link
Collaborator

@AugustinMauroy AugustinMauroy commented Aug 5, 2024 •
edited
Loading

Description

  • Adding some unit test
  • Change little bit script key of package.json

Validation

  • CI should be green
Capture d’écran 2024-08-05 à 16 08 11

Related Issues

#19

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I've covered new added functionality with unit tests if necessary.

@AugustinMauroy AugustinMauroy requested a review from a team as a code owner August 5, 2024 14:07
@AugustinMauroy AugustinMauroy changed the title Test test: introduce Aug 5, 2024
ovflowd
ovflowd approved these changes Aug 5, 2024
View reviewed changes
Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

canerakdas
canerakdas approved these changes Aug 7, 2024
View reviewed changes
Copy link
Member

@canerakdas canerakdas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AugustinMauroy AugustinMauroy merged commit fbad77a into main Aug 8, 2024
7 checks passed
@AugustinMauroy AugustinMauroy deleted the test branch October 4, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ovflowd ovflowd ovflowd approved these changes

@canerakdas canerakdas canerakdas approved these changes

@flakey5 flakey5 flakey5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AugustinMauroy @ovflowd @canerakdas @flakey5