Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workflow: setup basic #17

Merged
merged 5 commits into from
Jun 5, 2024
Merged

workflow: setup basic #17

merged 5 commits into from
Jun 5, 2024

Conversation

AugustinMauroy
Copy link
Collaborator

  • Adding Openssf scorecard (workflow and badge)
  • Adding codeQL for js and ts
  • Adding dependency review

@AugustinMauroy AugustinMauroy requested a review from a team as a code owner May 31, 2024 10:16
@AugustinMauroy AugustinMauroy linked an issue May 31, 2024 that may be closed by this pull request
Add base GitHub Action Templates (Hardener Runner, etc) based on the Node.js Website #14
Closed
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

bmuenzenmeyer
bmuenzenmeyer reviewed Jun 2, 2024
View reviewed changes
Copy link
Collaborator

@bmuenzenmeyer bmuenzenmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed that the harden-runner step is inconsistently defined

.github/workflows/scorecard.yml Outdated Show resolved Hide resolved
.github/workflows/dependency-review.yml Outdated Show resolved Hide resolved
.github/workflows/codeql.yml Outdated Show resolved Hide resolved
@AugustinMauroy
Copy link
Collaborator Author

Noticed that the harden-runner step is inconsistently defined

I'm sorry I didn't get what do you mean

@ovflowd
Copy link
Member

ovflowd commented Jun 5, 2024

cc @bmuenzenmeyer ☝️

@bmuenzenmeyer
Copy link
Collaborator

it was resolved with all my suggestions - different steps had different SHAs for harden-runner - its is now fixed

@AugustinMauroy AugustinMauroy merged commit 7290e52 into main Jun 5, 2024
5 checks passed
@AugustinMauroy AugustinMauroy deleted the openssf-scorecard branch June 5, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmuenzenmeyer bmuenzenmeyer bmuenzenmeyer approved these changes

@fraxken fraxken fraxken approved these changes

@flakey5 flakey5 flakey5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add base GitHub Action Templates (Hardener Runner, etc) based on the Node.js Website
5 participants
@AugustinMauroy @ovflowd @bmuenzenmeyer @fraxken @flakey5