-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Security updates #43
base: master
Are you sure you want to change the base?
Security updates #43
Conversation
when using https and/or httpAdminRoot
Having created a reference to this, it should be used in the code. More consistent and more obvious. Also added reason why node var is created.
Since node is created as a reference to the correct this object, it should be used throughout.
Also added some minor tweaks to use the node var instead of this for consistency and more obvious code. |
In order to retain a consistent reference to the nodes `this`, a variable called | ||
`node` is created pointing to `this`. `this`/`node` contains the information | ||
related to the created instance of the node. You would typically pass the nodes | ||
properties, `config`. to to `node` as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to to ? to the - maybe ? or...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haha, well done Dave, you spotted the deliberate typo to make sure you were checking!
Do you want me to change it or will you do it directly? Sorry, not done many PR's and I'm not sure what the normal protocol is.
Hi, as discussed on Slack.
Added a few clarifying points on security settings.