Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for RX timeout #353

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dankeder
Copy link

@dankeder dankeder commented Oct 1, 2015

Don't hang indefinitely when the client stops sending data to us. Close the
connection when timeout is reached.

Don't hang indefinitely when the client stops sending data to us. Close the
connection when timeout is reached.
@felixge
Copy link
Collaborator

felixge commented Jan 11, 2017

#412

@tunnckoCore tunnckoCore self-assigned this Jan 29, 2020
@tunnckoCore
Copy link
Member

tunnckoCore commented Jan 29, 2020

Good one.

hint: add option to control maxTimeout

linking #545 and #415 as reminder, because I'm there mostly.

if (this._rxTimeoutId !== null) {
clearTimeout(this._rxTimeoutId);
}
this._rxTimeoutId = setTimeout(function() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use arrow function to preserve the this

@tunnckoCore tunnckoCore removed their assignment Apr 3, 2022
@tunnckoCore tunnckoCore added Status: Awaiting Response Waiting author or someone to respond to question or clarification Status: Blocked Another issue needs to be resolved first or an external blocker. labels Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Awaiting Response Waiting author or someone to respond to question or clarification Status: Blocked Another issue needs to be resolved first or an external blocker.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants